fixes deeplinking in uiscenedelegate migrated projects #170452
Merged
+59
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, we still want it for people that have already auto migrated, for those that already have attempted to migrated before this all started and for those that choose to manually migrate. |
hellohuanlin
approved these changes
Jun 17, 2025
| } | ||
| } | ||
|
|
||
| static NSDictionary<UIApplicationOpenURLOptionsKey, id>* ConvertOptions( |
There was a problem hiding this comment.
nit: FLTConvertSceneOpenURLOptions
There was a problem hiding this comment.
FYI that is a static function which means it only has file scope, the symbol isn't exported so there is no risk that it will collide with other functions. Those sorts of naming conventions are important for functions that have external linkage.
There was a problem hiding this comment.
the symbol isn't exported so there is no risk that it will collide with other functions
Say you have
static void foo() {
// print foo
}
Then one of the included header has:
void foo() {
// print bar
}
This won't compile right? (haven't tried)
There was a problem hiding this comment.
That's not a problem, you can just change the name at that point safely because the symbol doesn't exist beyond the translation unit.
There was a problem hiding this comment.
Also, something named foo in a header would be an exported symbol which should follow a safe naming scheme.
2c592ad to
33a53c4
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 19, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 19, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 19, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 19, 2025
Roll Flutter from 8303a96a0a99 to 85a9b4f38906 (93 revisions) flutter/flutter@8303a96...85a9b4f 2025-06-19 [email protected] Roll Skia from af242598f14d to 794936b23812 (2 revisions) (flutter/flutter#170875) 2025-06-19 [email protected] Drop support for 21/22 Lollipop (flutter/flutter#170748) 2025-06-19 [email protected] Roll Dart SDK from 6020126c10e8 to bce9abe03175 (1 revision) (flutter/flutter#170872) 2025-06-19 [email protected] Roll Skia from df97f7f407db to af242598f14d (4 revisions) (flutter/flutter#170867) 2025-06-19 [email protected] Roll Skia from 1d8f7ebd23cc to df97f7f407db (5 revisions) (flutter/flutter#170864) 2025-06-19 [email protected] Roll Dart SDK from 4ab716b09e9d to 6020126c10e8 (1 revision) (flutter/flutter#170862) 2025-06-19 [email protected] Roll Skia from 291d41414fa7 to 1d8f7ebd23cc (2 revisions) (flutter/flutter#170857) 2025-06-19 [email protected] Roll Dart SDK from b32559bca3cc to 4ab716b09e9d (9 revisions) (flutter/flutter#170855) 2025-06-19 [email protected] remove --start-paused flag by default and set useDwdsWebSocketConnect… (flutter/flutter#170612) 2025-06-18 [email protected] Engine builders no longer require `is_fusion` (flutter/flutter#170849) 2025-06-18 [email protected] Roll Skia from 5f110d5f48a3 to 291d41414fa7 (2 revisions) (flutter/flutter#170836) 2025-06-18 [email protected] Use a shared vertex buffer for rendering layers. (flutter/flutter#170717) 2025-06-18 [email protected] fixes deeplinking in uiscenedelegate migrated projects (flutter/flutter#170452) 2025-06-18 [email protected] [Impeller] fix array uniforms on GLES backend. (flutter/flutter#170710) 2025-06-18 [email protected] [Impeller] Update README to add section about custom embedders. (flutter/flutter#170077) 2025-06-18 [email protected] Escape the forbidden strings in the regex used to check test command output (flutter/flutter#170702) 2025-06-18 [email protected] License cpp jun16 (flutter/flutter#170716) 2025-06-18 [email protected] Work around newer compilers requiring the satisfaction of three-way comparison of EncodableValue. (flutter/flutter#170822) 2025-06-18 [email protected] Update didUnmountRenderObject text description (flutter/flutter#169628) 2025-06-18 [email protected] Roll Skia from 297dbc32a6c7 to 5f110d5f48a3 (2 revisions) (flutter/flutter#170821) 2025-06-18 [email protected] Add an initial "Using feature flags" doc for the team. (flutter/flutter#170767) 2025-06-18 [email protected] Feat: Add mouse cursor for CupertinoDialogAction (flutter/flutter#169051) 2025-06-18 [email protected] Update `Engine-artifacts.md` to reflect flutter/cocoon/4785 (flutter/flutter#170751) 2025-06-18 [email protected] `CupertinoPicker` new onChanged behaviour (flutter/flutter#170202) 2025-06-18 [email protected] Rename `entryPointBaseUrl` to `entrypointBaseUrl` (flutter/flutter#170166) 2025-06-18 [email protected] Roll Skia from 1cb13a21b547 to 297dbc32a6c7 (4 revisions) (flutter/flutter#170809) 2025-06-18 [email protected] Roll Packages from 25d4fa4 to 715a0a5 (2 revisions) (flutter/flutter#170808) 2025-06-18 [email protected] Roll Skia from 0a106c038cd0 to 1cb13a21b547 (1 revision) (flutter/flutter#170801) 2025-06-18 [email protected] Add `--profile-microtasks` switch (flutter/flutter#170690) 2025-06-18 [email protected] Roll Skia from ff7fffa5dac5 to 0a106c038cd0 (3 revisions) (flutter/flutter#170795) 2025-06-18 [email protected] Add example for CupertinoExpansionTile transition modes (flutter/flutter#170335) 2025-06-18 [email protected] feat: Add radius to DividerThemeData. (flutter/flutter#169739) 2025-06-18 [email protected] Roll Skia from 75af9450b121 to ff7fffa5dac5 (3 revisions) (flutter/flutter#170772) 2025-06-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "add run_gradle_lock_files_check.dart for new PR's that modify gradle files (#169245)" (flutter/flutter#170770) 2025-06-17 [email protected] Started bridging the scene delegate to the lifecycle delegate for shortcuts (flutter/flutter#170180) 2025-06-17 [email protected] [ui] npot display_list allocation. (flutter/flutter#170447) 2025-06-17 [email protected] Prefer .of over .from (flutter/flutter#170750) 2025-06-17 [email protected] Fix RawGestureDetector semantics (flutter/flutter#170549) 2025-06-17 [email protected] Use correct type for filterIdentifier (flutter/flutter#170343) 2025-06-17 [email protected] Remove and inline `license_header.txt` (flutter/flutter#170475) 2025-06-17 [email protected] add run_gradle_lock_files_check.dart for new PR's that modify gradle files (flutter/flutter#169245) 2025-06-17 [email protected] Roll Dart SDK from 4fad61257b29 to b32559bca3cc (3 revisions) (flutter/flutter#170746) 2025-06-17 [email protected] [release] Sync stable changelog to master (flutter/flutter#170691) 2025-06-17 [email protected] Roll Packages from 03a6abb to 25d4fa4 (5 revisions) (flutter/flutter#170743) 2025-06-17 [email protected] [ Widget Preview ] Remove support for synthetic package:flutter_gen (flutter/flutter#170602) 2025-06-17 [email protected] Roll Skia from 8879db3b3319 to 75af9450b121 (4 revisions) (flutter/flutter#170739) ...
feduke-nukem
pushed a commit
to Yobari-Timeliners/golub
that referenced
this pull request
Jun 20, 2025
Roll Flutter from 8303a96a0a99 to 85a9b4f38906 (93 revisions) flutter/flutter@8303a96...85a9b4f 2025-06-19 [email protected] Roll Skia from af242598f14d to 794936b23812 (2 revisions) (flutter/flutter#170875) 2025-06-19 [email protected] Drop support for 21/22 Lollipop (flutter/flutter#170748) 2025-06-19 [email protected] Roll Dart SDK from 6020126c10e8 to bce9abe03175 (1 revision) (flutter/flutter#170872) 2025-06-19 [email protected] Roll Skia from df97f7f407db to af242598f14d (4 revisions) (flutter/flutter#170867) 2025-06-19 [email protected] Roll Skia from 1d8f7ebd23cc to df97f7f407db (5 revisions) (flutter/flutter#170864) 2025-06-19 [email protected] Roll Dart SDK from 4ab716b09e9d to 6020126c10e8 (1 revision) (flutter/flutter#170862) 2025-06-19 [email protected] Roll Skia from 291d41414fa7 to 1d8f7ebd23cc (2 revisions) (flutter/flutter#170857) 2025-06-19 [email protected] Roll Dart SDK from b32559bca3cc to 4ab716b09e9d (9 revisions) (flutter/flutter#170855) 2025-06-19 [email protected] remove --start-paused flag by default and set useDwdsWebSocketConnect… (flutter/flutter#170612) 2025-06-18 [email protected] Engine builders no longer require `is_fusion` (flutter/flutter#170849) 2025-06-18 [email protected] Roll Skia from 5f110d5f48a3 to 291d41414fa7 (2 revisions) (flutter/flutter#170836) 2025-06-18 [email protected] Use a shared vertex buffer for rendering layers. (flutter/flutter#170717) 2025-06-18 [email protected] fixes deeplinking in uiscenedelegate migrated projects (flutter/flutter#170452) 2025-06-18 [email protected] [Impeller] fix array uniforms on GLES backend. (flutter/flutter#170710) 2025-06-18 [email protected] [Impeller] Update README to add section about custom embedders. (flutter/flutter#170077) 2025-06-18 [email protected] Escape the forbidden strings in the regex used to check test command output (flutter/flutter#170702) 2025-06-18 [email protected] License cpp jun16 (flutter/flutter#170716) 2025-06-18 [email protected] Work around newer compilers requiring the satisfaction of three-way comparison of EncodableValue. (flutter/flutter#170822) 2025-06-18 [email protected] Update didUnmountRenderObject text description (flutter/flutter#169628) 2025-06-18 [email protected] Roll Skia from 297dbc32a6c7 to 5f110d5f48a3 (2 revisions) (flutter/flutter#170821) 2025-06-18 [email protected] Add an initial "Using feature flags" doc for the team. (flutter/flutter#170767) 2025-06-18 [email protected] Feat: Add mouse cursor for CupertinoDialogAction (flutter/flutter#169051) 2025-06-18 [email protected] Update `Engine-artifacts.md` to reflect flutter/cocoon/4785 (flutter/flutter#170751) 2025-06-18 [email protected] `CupertinoPicker` new onChanged behaviour (flutter/flutter#170202) 2025-06-18 [email protected] Rename `entryPointBaseUrl` to `entrypointBaseUrl` (flutter/flutter#170166) 2025-06-18 [email protected] Roll Skia from 1cb13a21b547 to 297dbc32a6c7 (4 revisions) (flutter/flutter#170809) 2025-06-18 [email protected] Roll Packages from 25d4fa425508 to 715a0a5c4fdd (2 revisions) (flutter/flutter#170808) 2025-06-18 [email protected] Roll Skia from 0a106c038cd0 to 1cb13a21b547 (1 revision) (flutter/flutter#170801) 2025-06-18 [email protected] Add `--profile-microtasks` switch (flutter/flutter#170690) 2025-06-18 [email protected] Roll Skia from ff7fffa5dac5 to 0a106c038cd0 (3 revisions) (flutter/flutter#170795) 2025-06-18 [email protected] Add example for CupertinoExpansionTile transition modes (flutter/flutter#170335) 2025-06-18 [email protected] feat: Add radius to DividerThemeData. (flutter/flutter#169739) 2025-06-18 [email protected] Roll Skia from 75af9450b121 to ff7fffa5dac5 (3 revisions) (flutter/flutter#170772) 2025-06-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "add run_gradle_lock_files_check.dart for new PR's that modify gradle files (#169245)" (flutter/flutter#170770) 2025-06-17 [email protected] Started bridging the scene delegate to the lifecycle delegate for shortcuts (flutter/flutter#170180) 2025-06-17 [email protected] [ui] npot display_list allocation. (flutter/flutter#170447) 2025-06-17 [email protected] Prefer .of over .from (flutter/flutter#170750) 2025-06-17 [email protected] Fix RawGestureDetector semantics (flutter/flutter#170549) 2025-06-17 [email protected] Use correct type for filterIdentifier (flutter/flutter#170343) 2025-06-17 [email protected] Remove and inline `license_header.txt` (flutter/flutter#170475) 2025-06-17 [email protected] add run_gradle_lock_files_check.dart for new PR's that modify gradle files (flutter/flutter#169245) 2025-06-17 [email protected] Roll Dart SDK from 4fad61257b29 to b32559bca3cc (3 revisions) (flutter/flutter#170746) 2025-06-17 [email protected] [release] Sync stable changelog to master (flutter/flutter#170691) 2025-06-17 [email protected] Roll Packages from 03a6abbedabb to 25d4fa425508 (5 revisions) (flutter/flutter#170743) 2025-06-17 [email protected] [ Widget Preview ] Remove support for synthetic package:flutter_gen (flutter/flutter#170602) 2025-06-17 [email protected] Roll Skia from 8879db3b3319 to 75af9450b121 (4 revisions) (flutter/flutter#170739) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #170350
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.