Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Impeller] Remove use of simple Skia objects #170494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2025
Merged

[Impeller] Remove use of simple Skia objects #170494

merged 1 commit into from
Jun 14, 2025

Conversation

flar
Copy link
Contributor

@flar flar commented Jun 11, 2025

Just a few remaining references to Skia types like SkScalar and SkSize/Rect. After this most of Impeller is Skia-free except for areas that deal with fonts, images, and the toolkit/interop and typographer directories.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Jun 11, 2025
jonahwilliams
jonahwilliams approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@flar flar added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Jun 12, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 14, 2025
Merged via the queue into flutter:master with commit c0db033 Jun 14, 2025
183 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 14, 2025
alex-medinsh pushed a commit to alex-medinsh/flutter that referenced this pull request Jun 16, 2025
@flar @alex-medinsh
[Impeller] Remove use of simple Skia objects (flutter#170494)
58d7f9d 
Just a few remaining references to Skia types like SkScalar and
SkSize/Rect. After this most of Impeller is Skia-free except for areas
that deal with fonts, images, and the `toolkit/interop` and
`typographer` directories.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
b3eee45 
…er#170494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
6927af6 
…er#170494)
This was referenced Jun 17, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
abadf2a 
…er#170494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
be3d76c 
…er#170494)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
b2583b3 
…er#170494)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
9d0692f 
…er#170494)
This was referenced Jun 17, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
fffade6 
…er#170494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
61fc04c 
…er#170494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
9fb6a87 
…er#170494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
1596682 
…er#170494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
bf75667 
…er#170494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
182e889 
…er#170494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
6ec6509 
…er#170494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
e55afbd 
…er#170494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
14957a4 
…er#170494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
d3141e5 
…er#170494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
237daf2 
…er#170494)
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@flar @mboetger
[Impeller] Remove use of simple Skia objects (flutter#170494)
34335f2 
Just a few remaining references to Skia types like SkScalar and
SkSize/Rect. After this most of Impeller is Skia-free except for areas
that deal with fonts, images, and the `toolkit/interop` and
`typographer` directories.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
b7893b1 
…er#170494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
1afde3b 
…er#170494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
1f48606 
…er#170494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
3318e74 
…er#170494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
c0db0332b [Impeller] Remove use of simple Skia objects (flutter/flutt…
d8ac538 
…er#170494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flar @jonahwilliams