Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update Linux embedder to new semantics flags API #170497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

Update Linux embedder to new semantics flags API #170497

merged 1 commit into from
Jun 17, 2025

Conversation

robert-ancell
Copy link
Contributor

As changed in #167738.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically a: desktop Running on desktop labels Jun 12, 2025
@robert-ancell robert-ancell mentioned this pull request Jun 12, 2025
Merged
9 tasks
@loic-sharma
Copy link
Member

@robert-ancell Could you rebase off the latest master branch? We switched the tristate flags to use an enum instead of two booleans. See: #170505

@robert-ancell robert-ancell force-pushed the linux-semantics-flags2 branch from c46db90 to c88d28c Compare June 15, 2025 22:32
loic-sharma
loic-sharma approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hannah-hyj
hannah-hyj approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robert-ancell robert-ancell added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 16, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 16, 2025
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Jun 16, 2025

autosubmit label was removed for flutter/flutter/170497, because - The status or check suite Linux linux_fuchsia_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@robert-ancell robert-ancell enabled auto-merge June 17, 2025 03:43
@robert-ancell robert-ancell added this pull request to the merge queue Jun 17, 2025
Merged via the queue into flutter:master with commit 117c60e Jun 17, 2025
175 of 176 checks passed
@robert-ancell robert-ancell deleted the linux-semantics-flags2 branch June 17, 2025 04:39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
d905739 
…lutter#170497)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
9847692 
…lutter#170497)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
c6346ca 
…lutter#170497)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
7663024 
…lutter#170497)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
239e87a 
…lutter#170497)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
ceb6213 
…lutter#170497)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
aff9cb5 
…lutter#170497)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
aaf7c86 
…lutter#170497)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
f89c2a2 
…lutter#170497)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
1d3176d 
…lutter#170497)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
c336f94 
…lutter#170497)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
ea45413 
…lutter#170497)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
e032572 
…lutter#170497)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
2433a07 
…lutter#170497)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
7429000 
…lutter#170497)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
1964301 
…lutter#170497)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
f822298 
…lutter#170497)
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@robert-ancell @mboetger
Update Linux embedder to new semantics flags API (flutter#170497)
e590aa2 
As changed in flutter#167738.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
ea37f9e 
…lutter#170497)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
b199d95 
…lutter#170497)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
8d162e9 
…lutter#170497)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
7e49889 
…lutter#170497)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
117c60edc Update Linux embedder to new semantics flags API (flutter/f…
a4165c1 
…lutter#170497)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

@hannah-hyj hannah-hyj hannah-hyj approved these changes

@cbracken cbracken Awaiting requested review from cbracken

Assignees
No one assigned
Labels
a: desktop Running on desktop engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robert-ancell @loic-sharma @hannah-hyj