Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Impeller] disable lossy texture compression. #170596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 14, 2025
Merged

[Impeller] disable lossy texture compression. #170596

merged 2 commits into from
Jun 14, 2025

Conversation

jonahwilliams
Copy link
Contributor

Fixes #170056
Fixes #170089

Lossy texture compression can cause rendering artifacts in certain kinds of images. Disable automatic application of it.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Jun 13, 2025
@jtmcdole
Copy link
Member

What compression where they using on Metal?

@jtmcdole
Copy link
Member

Update branch to pick up the actions change.

@jonahwilliams
Copy link
Contributor Author

I don't believe the algorithm is documented

@jonahwilliams jonahwilliams added autosubmit Merge PR when tree becomes green via auto submit App labels Jun 13, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 13, 2025
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Jun 13, 2025

autosubmit label was removed for flutter/flutter/170596, because - The status or check suite Linux linux_web_engine_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 13, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 13, 2025
Merged via the queue into flutter:master with commit c64e652 Jun 14, 2025
185 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
c5335fd 
…ter#170596)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
324bf45 
…ter#170596)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
bf25a4e 
…ter#170596)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
153b160 
…ter#170596)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
633d058 
…ter#170596)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
8d05e23 
…ter#170596)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
ddbec97 
…ter#170596)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
fd73727 
…ter#170596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
79d541a 
…ter#170596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
b277d27 
…ter#170596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
4d8e15d 
…ter#170596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
6b11640 
…ter#170596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
840cd0e 
…ter#170596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
c3d662a 
…ter#170596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
9209941 
…ter#170596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
4a547e6 
…ter#170596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
04ec491 
…ter#170596)
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@mboetger
[Impeller] disable lossy texture compression. (flutter#170596)
aaa8382 
Fixes flutter#170056
Fixes flutter#170089

Lossy texture compression can cause rendering artifacts in certain kinds
of images. Disable automatic application of it.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
5ac50dd 
…ter#170596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
284f1a4 
…ter#170596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
84687c0 
…ter#170596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
6da5886 
…ter#170596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
c64e652bf [Impeller] disable lossy texture compression. (flutter/flut…
8465c1b 
…ter#170596)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtmcdole jtmcdole jtmcdole approved these changes

Assignees
No one assigned
Labels
engine flutter/engine related. See also e: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Codec.getNextFrame().image creates artifacts in semi-transparent pixels [iOS] Rendering images with borders causes jagged/aliased edges
2 participants
@jonahwilliams @jtmcdole