Reland "[native assets] Build dev dependencies in flutter test integration_test"
#170728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d988129 to
58761bc
Compare
matanlurey
approved these changes
Jun 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 17, 2025
…test integration_test`" (flutter/flutter#170728)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 17, 2025
…test integration_test`" (flutter/flutter#170728)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 17, 2025
…test integration_test`" (flutter/flutter#170728)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 17, 2025
…test integration_test`" (flutter/flutter#170728)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 17, 2025
…test integration_test`" (flutter/flutter#170728)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 17, 2025
…test integration_test`" (flutter/flutter#170728)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 17, 2025
…test integration_test`" (flutter/flutter#170728)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
…test integration_test`" (flutter/flutter#170728)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
…test integration_test`" (flutter/flutter#170728)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
…test integration_test`" (flutter/flutter#170728)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
…test integration_test`" (flutter/flutter#170728)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
…test integration_test`" (flutter/flutter#170728)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
…test integration_test`" (flutter/flutter#170728)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
…test integration_test`" (flutter/flutter#170728)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 19, 2025
…test integration_test`" (flutter/flutter#170728)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 19, 2025
…test integration_test`" (flutter/flutter#170728)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 19, 2025
…test integration_test`" (flutter/flutter#170728)
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
…ration_test`" (flutter#170728) Reland flutter#170686. Closes: flutter#168961. Original PR in first commit. Fix in subsequent commit: * Do process invocation of `flutter pub add` in a different way. Fixes: `ProcessException: %1 is not a valid Win32 application` Reproduced locally by changing dev/devicelab/bin/tasks/native_assets_android.dart to `DeviceOperatingSystem.windows` and verified the `flutter pub add` call now succeeds. (Also, moved the add integration test into the create test project to avoid having multiple `flutter pub get`s.) Third time is the charm.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
…test integration_test`" (flutter/flutter#170728)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
…test integration_test`" (flutter/flutter#170728)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
…test integration_test`" (flutter/flutter#170728)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
…test integration_test`" (flutter/flutter#170728)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
…test integration_test`" (flutter/flutter#170728)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland #170686.
Closes: #168961.
Original PR in first commit. Fix in subsequent commit:
flutter pub addin a different way.Fixes:
ProcessException: %1 is not a valid Win32 applicationReproduced locally by changing dev/devicelab/bin/tasks/native_assets_android.dart to
DeviceOperatingSystem.windowsand verified theflutter pub addcall now succeeds.(Also, moved the add integration test into the create test project to avoid having multiple
flutter pub gets.)Third time is the charm.