[CP-beta]Prevent --web-experimental-hot-reload on web-server #170744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running on the web-server device hot reload option will default to disabled when `-d web-server` is also passed. This is temporary until the app can start correctly with hot reload enabled. Issue: dart-lang/sdk#60289
|
@nshahan please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
matanlurey
approved these changes
Jun 17, 2025
reidbaker
approved these changes
Jun 17, 2025
eb3ca25
into
flutter:flutter-3.34-candidate.0
143 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
dart-lang/sdk#60289
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
Automatically disable
web-experimental-hot-reloadwhen running flutter usingweb-serverdevice.Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
Without this fix apps launched with
flutter run -d web-serverdo not load in the browser. The app is never started.Workaround:
Is there a workaround for this issue?
You can work around the issue by passing the same argument that this cherry pick automatically adds:
flutter run -d web-server --no-web-experimental-hot-reload.Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
flutter run -d web-serverand verify that the app can be loaded in a web browser.