feat: Use engine_stamp.json in flutter tool #171454
Open
+309
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flutter tool will now download and use an `engine_stamp.json` file to determine the engine version, content hash, build date, and commit date. This change provides support for content hashed engine artifacts, who's revision (the hash) is not a git commit sha. A side benifit is "git" is only used at build time to extract this information. Content hashed artifacts are not enabled yet; bin/internal/engine.version (releases) and the shell updaters still look for the git commit sha. One can test this out by setting FLUTTER_PREBUILD_ENGINE_VERSION to the content hash.
|
Failing tests look real - so moving to draft while I figure out how to recreate. |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Waiting on g3fix to retest. |
|
G3Fix works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flutter tool will now download and use an
engine_stamp.jsonfile to determine the engine version, content hash, build date, and commit date.The file is treated as a new
DevelopmentArtifact.informativeand is fetched before flutterVersion is used. This ensures we have build information for a clean checkout with no bin/cache folder. Users that download from flutter.dev will have engine_stamp.json, so its a no-op.This change provides support for content hashed engine artifacts, who's revision (the hash) is not a git commit sha. A side benefit is "git" is only used at build time to extract this information.
Note
Content hashed artifacts are not enabled yet for downloads; bin/internal/engine.version (releases) and the shell updaters still look for the git commit sha. One can test this out by setting
FLUTTER_PREBUILD_ENGINE_VERSIONto the content hash.