It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Alright, this is now considerably more nuanced.

• DefaultTextEditingShortcuts no longer maps Shift-Delete to the same action as Delete, but instead defines a block specifically for clipboard-related shortcuts _clipboardShortcuts and selectively includes it for Android, Linux and Windows. MacOS is excluded, which matches the previous behaviour because MacOS also excudes _commonShortcuts where ^X, ^C and ^V were previously defined.
• The explicit exclusion of mappings for clipboard actions in _webDisablingTextShortcuts now dynamically generates its exclusions from _clipboardShortcuts rather than explicitly specifying ^X, ^C and ^V.
• Automated testing includes tests of clipboard actions, limited to the target platform variants where they are defined. A simple fluent syntax is introduced to keep the definition of these target platform variant sets concise.

All tests pass.

Hmm, what does this mean?:

I thought it had added the label because the changes intersected the test suite. They still do, but the label has been removed?

Hmm, what does this mean?:

The a: tests label applies when there are changes to the testing APIs. It was previously added because there were some changes to the widget_tester.dart file (the fluent API). As those changes are reverted the label is no more needed.

About the ci.yaml validation failure, usually rebasing the PR to the tip of the tree fixes it, can you try?

autosubmit label was removed for flutter/flutter/178561, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

autosubmit label was removed for flutter/flutter/178561, because - The status or check suite Linux analyzer_benchmark has failed. Please fix the issues identified (or deflake) before re-applying this label.

@logiclrd It looks like there's a few lints you'll need to address before we can merge this in: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8695004791188624433/+/u/run_test.dart_for_analyze_shard_and_subshard_None/stdout

Analyzing Flutter repository...                                    23.3s


   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter/test/widgets/default_text_editing_shortcuts_test.dart:1133:13 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter/test/widgets/default_text_editing_shortcuts_test.dart:1135:13 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter/test/widgets/default_text_editing_shortcuts_test.dart:1178:13 • omit_obvious_local_variable_types
   info • Omit the type annotation on a local variable when the type is obvious • packages/flutter/test/widgets/default_text_editing_shortcuts_test.dart:1180:13 • omit_obvious_local_variable_types
4 issues found. (4 new) • analyzed 5423 files (ran in 23.31s)
Analysis benchmark written to analysis_benchmark.json ({time: 23.307, issues: 4}).

autosubmit label was removed for flutter/flutter/178561, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.