Make sure that a DecoratedBox doesn't crash in 0x0 environment #180329
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds a regression test for an issue where DecoratedBox crashes when it has a zero size and a gradient. While the test case is a good addition, its current implementation with an empty BoxDecoration does not trigger the crash condition. I've provided a suggestion to include a gradient in the decoration to ensure the test correctly covers the scenario from issue #6537. The fix for the underlying crash itself appears to be missing from this PR.
| const Directionality( | ||
| textDirection: TextDirection.ltr, | ||
| child: Center( | ||
| child: SizedBox.shrink(child: DecoratedBox(decoration: BoxDecoration())), |
There was a problem hiding this comment.
The current test setup with an empty BoxDecoration() doesn't trigger the crash condition reported in issue #6537. The crash occurs when a gradient is present on a zero-sized DecoratedBox. To properly test for this scenario, you should add a gradient to the BoxDecoration.
child: SizedBox.shrink(child: DecoratedBox(decoration: BoxDecoration(gradient: LinearGradient(begin: Alignment.topLeft, end: Alignment.bottomRight, colors: <Color>[Color(0xFF000000), Color(0xFFFFFFFF)])))),
This is my attempt to handle #6537 for the DecoratedBox widget.