Fix deprecation validator message to require leading v#180467
Fix deprecation validator message to require leading v#180467auto-submit[bot] merged 17 commits intoflutter:masterfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates a deprecation validator error message and its corresponding documentation. The change in dev/bots/analyze.dart clarifies that the version string must be prefixed with a 'v', making the error message more specific. The update in docs/contributing/Tree-hygiene.md aligns the documentation with this requirement. The changes are correct and improve consistency.
Piinks
left a comment
There was a problem hiding this comment.
Thanks for sending another PR! It looks like this is failing some checks, can you take a look?
|
Thanks for the review @Piinks! This PR is addressing #178246, which reports that the deprecations validator truncates its error message before the required leading You’re right about the failing checks — after taking a closer look, it seems the failures are due to tests that assert the exact validator error message text. Since this PR updates the wording of that message (to explicitly require a leading I’ll track down the affected tests and update their expected error messages to match the new validator output, and push a follow-up commit shortly. Thanks for pointing this out! |
|
Holding off on the re-review here until the test failures are addressed. 👍 |
|
I think it is ready for another review. |
Piinks
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the updates here!
navaronbracke
left a comment
There was a problem hiding this comment.
Just a suggestion on how to test this.
|
@navaronbracke I have added the suggested updates. Can you give another review |
Co-authored-by: Navaron Bracke <[email protected]>
Fixes flutter#178246 This PR updates the deprecation validator error message to clarify that the version must include a leading `v` (for example, `v1.2.3`). It also updates the deprecation template documentation to match the validator requirement. No functional behavior is changed; this only improves clarity and consistency between the validator and documentation. --------- Co-authored-by: Navaron Bracke <[email protected]>
Fixes #178246
This PR updates the deprecation validator error message to clarify that
the version must include a leading
v(for example,v1.2.3).It also updates the deprecation template documentation to match the
validator requirement.
No functional behavior is changed; this only improves clarity and
consistency between the validator and documentation.