3.38.8 changelog#181390
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
There was a problem hiding this comment.
Code Review
This pull request adds a changelog entry for version 3.38.8. The review includes a suggestion to rephrase the new entry to better align with the repository's documentation guidelines. The current entry is a direct copy of the issue title, which is discouraged in favor of a more user-friendly description.
|
|
||
| ## [3.38.8](https://github.com/flutter/flutter/releases/tag/3.38.8) | ||
|
|
||
| - [flutter/178151](https://github.com/flutter/flutter/issues/178151) - `flutter run -d chrome` can crash with a `DartDevelopmentServiceException` if the application shuts down during the startup sequence. |
There was a problem hiding this comment.
The changelog entry appears to be a direct copy of the issue title. The repository's style guide for hotfix documentation (docs/releases/Hotfix-Documentation-Best-Practices.md) advises against this, recommending instead a concise, user-focused description of the problem.
To improve clarity for users scanning the changelog, I suggest rephrasing it.
| - [flutter/178151](https://github.com/flutter/flutter/issues/178151) - `flutter run -d chrome` can crash with a `DartDevelopmentServiceException` if the application shuts down during the startup sequence. | |
| - [flutter/178151](https://github.com/flutter/flutter/issues/178151) - `flutter run -d chrome` may crash if the application shuts down during startup. |
References
- The repository's documentation best practices, detailed in
docs/releases/Hotfix-Documentation-Best-Practices.mdand summarized inCHANGELOG.md, state that changelog entries should not be direct copies of issue titles. They should be rewritten to be clear and easily scannable for users to understand the impact. (link)
|
I think the failures are releated to the post submit builds being queued. #181392 |
Pre-launch Checklist
///).