Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add getUniformMatX support for desktop and mobile#182117

Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom
walley892:get-uniform-matrix
Feb 11, 2026
Merged

Add getUniformMatX support for desktop and mobile#182117
auto-submit[bot] merged 3 commits intoflutter:masterfrom
walley892:get-uniform-matrix

Conversation

@walley892
Copy link
Contributor

@walley892 walley892 commented Feb 9, 2026

Adds getUniformMatX and getUniformMatXArray functions to desktop and mobile.

Also fixes a padding issue with mat3s on Vulkan.

@walley892 walley892 requested a review from gaaclarke February 9, 2026 22:08
@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically e: impeller Impeller rendering backend issues and features requests labels Feb 9, 2026
gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 9, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for mat2, mat3, and mat4 uniforms for desktop and mobile platforms by introducing getUniformMatX and getUniformMatXArray functions. It also includes a fix for a mat3 padding issue on Vulkan. The changes are well-tested with new shaders and test cases. I've found a couple of minor issues: an incorrect comment in the C++ reflector code regarding padding size, and a copy-paste error in a Dart documentation comment. Overall, this is a solid contribution that expands shader capabilities.

gaaclarke
gaaclarke reviewed Feb 9, 2026
View reviewed changes
@walley892 walley892 requested a review from gaaclarke February 10, 2026 21:53
@gaaclarke
Copy link
Member

gaaclarke commented Feb 10, 2026 

workingDirectory: /b/s/w/ir/x/w/flutter, executable: /b/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dart, arguments: [--enable-asserts, /b/s/w/ir/x/w/flutter/dev/bots/analyze_snippet_code.dart, --verbose]
bin/cache/pkg/sky_engine/lib/ui/painting.dart:5730:14: The method 'UniformMat2Slot' isn't defined for the type 'FragmentShader' (top-level declaration) (undefined_method)
bin/cache/pkg/sky_engine/lib/ui/painting.dart:5761:14: The method 'UniformMat3Slot' isn't defined for the type 'FragmentShader' (top-level declaration) (undefined_method)
bin/cache/pkg/sky_engine/lib/ui/painting.dart:5818:14: The method 'UniformMat4Slot' isn't defined for the type 'FragmentShader' (top-level declaration) (undefined_method)
Found 3 snippet code errors.

gaaclarke
gaaclarke approved these changes Feb 10, 2026
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (once CI is happy)

@walley892 walley892 added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 11, 2026
@auto-submit auto-submit bot added this pull request to the merge queue Feb 11, 2026
Merged via the queue into flutter:master with commit 409d626 Feb 11, 2026
183 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 11, 2026
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
f974103 
…flutter#182117)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
91cda8b 
…flutter#182117)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
7231bf7 
…flutter#182117)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
8b5548f 
…flutter#182117)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
928c2f4 
…flutter#182117)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
d0a291a 
…flutter#182117)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
a4ef4b2 
…flutter#182117)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
2e43a9b 
…flutter#182117)
This was referenced Feb 12, 2026
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
cf69adf 
…flutter#182117)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
b87a716 
…flutter#182117)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
eec1978 
…flutter#182117)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
c5868ac 
…flutter#182117)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
fd55f1e 
…flutter#182117)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
45a887e 
…flutter#182117)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
6044af0 
…flutter#182117)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
da76054 
…flutter#182117)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
beaa2aa 
…flutter#182117)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
c9fefcd 
…flutter#182117)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
9659938 
…flutter#182117)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
169cc11 
…flutter#182117)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
ed15a82 
…flutter#182117)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
cb18300 
…flutter#182117)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
080dcc0 
…flutter#182117)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2026
@engine-flutter-autoroll
409d62612 Add getUniformMatX support for desktop and mobile (flutter/…
b1e4225 
…flutter#182117)
rickhohler pushed a commit to rickhohler/flutter that referenced this pull request Feb 19, 2026
@walley892 @rickhohler
Add getUniformMatX support for desktop and mobile (flutter#182117)
27ac6e7 
Adds getUniformMatX and getUniformMatXArray functions to desktop and
mobile.

Also fixes a padding issue with mat3s on Vulkan.
@Piinks Piinks mentioned this pull request Feb 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels. platform-web Web applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@walley892 @gaaclarke