fix: use double quotes in settings.gradle.kts template#183081
fix: use double quotes in settings.gradle.kts template#183081ishaquehassan wants to merge 3 commits intoflutter:masterfrom
Conversation
Kotlin requires double quotes for string literals, not single quotes. The settings.gradle.kts.tmpl template was using single quotes which is invalid Kotlin syntax. Fixes flutter#182962
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request updates the settings.gradle.kts.tmpl template file, changing the single quotes used for the projectName template variable to double quotes. This change ensures the generated settings.gradle.kts file has valid Kotlin syntax for string literals.
The
settings.gradle.kts.tmpltemplate for Android plugins was using single quotes for string literals. Kotlin requires double quotes (") for string literals, while single quotes (') are only valid for character literals. This was introduced when the file was renamed fromsettings.gradletosettings.gradle.ktsin PR #173993, but the string format was not updated from Groovy style to Kotlin style.This PR changes:
Fixes #182962
Pre-launch Checklist
///).This PR is test-exempt because it modifies a template file that generates valid Kotlin syntax. The fix is a single-character change from single quotes to double quotes, which is a syntactic correction that does not require behavioral testing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.