Add a Clarification for the docs of suggestionsBuilder of SearchAnchor#183106
Open
ahmedsameha1 wants to merge 1 commit intoflutter:masterfrom
Open
Add a Clarification for the docs of suggestionsBuilder of SearchAnchor#183106ahmedsameha1 wants to merge 1 commit intoflutter:masterfrom
ahmedsameha1 wants to merge 1 commit intoflutter:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to clarify when the suggestionsBuilder is called. The added documentation is helpful but not entirely accurate. I've suggested a more precise wording to reflect that the builder is also called when the search view is first displayed, in addition to when the text changes.
| final SearchAnchorChildBuilder builder; | ||
|
|
||
| /// Called to get the suggestion list for the search view. | ||
| /// It is called only when the search text changes. |
Contributor
There was a problem hiding this comment.
This clarification is helpful, but not entirely accurate. The suggestionsBuilder is also called when the search view is first displayed (with an empty search text), not just when the text changes subsequently. A more precise phrasing would be better.
/// It is called when the search view is shown, and again whenever the search text changes.e1c0e16 to
c7be76e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle: #183105.