Add scrollPadding property to DropdownMenu#183109
Open
ishaquehassan wants to merge 2 commits intoflutter:masterfrom
Open
Add scrollPadding property to DropdownMenu#183109ishaquehassan wants to merge 2 commits intoflutter:masterfrom
ishaquehassan wants to merge 2 commits intoflutter:masterfrom
Conversation
This change adds a scrollPadding parameter to DropdownMenu, forwarding it to the internal TextField. Both TextField and SearchBar already expose this parameter, and since DropdownMenu wraps a TextField internally, it should forward this parameter for consistency. The default value is EdgeInsets.all(20.0) to match TextField's default and preserve existing behavior. Fixes flutter#182890
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a scrollPadding property to the DropdownMenu widget, which is then forwarded to the internal TextField. The default value is set to EdgeInsets.all(20.0) for consistency with TextField. The changes also include new tests to verify that the scrollPadding property is correctly passed and that its default value is applied as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds a
scrollPaddingproperty toDropdownMenu, forwarding it to the internalTextFieldwidget.DropdownMenuwraps aTextFieldinternally but did not expose thescrollPaddingparameter. BothTextFieldandSearchBaralready provide this property, soDropdownMenushould forward it for consistency. ThescrollPaddingproperty controls the padding around the text field when it scrolls into view (e.g., when the keyboard appears), allowing developers to ensure the field remains visible with appropriate spacing.The default value is
EdgeInsets.all(20.0), matchingTextField's default to preserve existing behavior.This PR implements the analysis from my earlier comment on this issue.
Related Issues
Fixes #182890
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.