Re-specify the ndk version in various test apps, to prevent ndk download#183134
Open
gmackall wants to merge 4 commits intoflutter:masterfrom
Open
Re-specify the ndk version in various test apps, to prevent ndk download#183134gmackall wants to merge 4 commits intoflutter:masterfrom
gmackall wants to merge 4 commits intoflutter:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Gradle configuration for the android_engine_test. A single line is added to dev/integration_tests/android_engine_test/android/app/build.gradle to explicitly set the ndkVersion to flutter.ndkVersion. This ensures that the build uses the NDK version specified by the Flutter SDK, preventing Gradle from downloading a default version and improving build reliability, especially in CI environments.
android_engine_testandroid_engine_test and hybrid_android_views test
added 2 commits
March 2, 2026 16:52
…m' into more_more_flake_elim
android_engine_test and hybrid_android_views test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I landed #179920 I was operating under the assumption that if there was no
ndkVersionspecified in theandroid {}block, AGP would use whatever NDK was present. This is not true - AGP has a default NDK version (dependent on your AGP version), and it checks only for that version (which is not the same as our pre-installed version in almost all (all?) cases).So we should re-add the
ndkVersion = flutter.ndkVersion. This is also present in our templates, so it isn't a ci specific hack. It will align the version that AGP looks for with the version we are hosting on CI, so we will stop downloading.