Build App and native asset frameworks for Add to App FlutterPluginRegistrant#183136
Open
vashworth wants to merge 3 commits intoflutter:masterfrom
Open
Build App and native asset frameworks for Add to App FlutterPluginRegistrant#183136vashworth wants to merge 3 commits intoflutter:masterfrom
vashworth wants to merge 3 commits intoflutter:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the capability to build App.xcframework and native asset frameworks for 'Add to App' scenarios, primarily enhancing the build swift-package command. The core logic is encapsulated in a new AppFrameworkAndNativeAssetsDependencies class, which handles the creation of XCFrameworks for different build configurations and platforms. The changes are well-structured and include corresponding updates to build targets and tests. My feedback focuses on improving code conciseness and adding a clarifying comment for better maintainability.
packages/flutter_tools/lib/src/build_system/targets/assets.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/lib/src/commands/build_swift_package.dart
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generates XCFrameworks for the App and any native assets and places them with the
FlutterPluginRegistrantSwift package.Build artifacts are stored in a
.cachedirectory to make incremental builds faster.Fixes #181209.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.