Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix docs on SingletonFlutterWindow.supportsShowingSystemContextMenu#183142

Open
loic-sharma wants to merge 1 commit intoflutter:masterfrom
loic-sharma:fix_context_menu_docs
Open

Fix docs on SingletonFlutterWindow.supportsShowingSystemContextMenu#183142
loic-sharma wants to merge 1 commit intoflutter:masterfrom
loic-sharma:fix_context_menu_docs

Conversation

@loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Mar 2, 2026

No description provided.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Mar 2, 2026
loic-sharma
loic-sharma commented Mar 2, 2026
View reviewed changes
engine/src/flutter/lib/ui/window.dart
/// is requested.
/// This option is used by [AdaptiveTextSelectionToolbar] to decide whether
/// to show system context menu, or to fallback to the default Flutter context
/// menu.
Copy link
Member Author

@loic-sharma loic-sharma Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from:

flutter/engine/src/flutter/lib/ui/platform_dispatcher.dart

Lines 1219 to 1224 in b063aeb

/// Whether showing system context menu is supported on the current platform.
///
/// This option is used by [AdaptiveTextSelectionToolbar] to decide whether
/// to show system context menu, or to fallback to the default Flutter context
/// menu.
bool get supportsShowingSystemContextMenu => _supportsShowingSystemContextMenu;

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 2, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for SingletonFlutterWindow.supportsShowingSystemContextMenu. The previous documentation incorrectly described spell check functionality. The new documentation clarifies that the property is related to showing the system context menu and is used by AdaptiveTextSelectionToolbar, aligning it with the documentation of the PlatformDispatcher property it forwards to.

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2026
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 3, 2026

autosubmit label was removed for flutter/flutter/183142, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hellohuanlin hellohuanlin hellohuanlin approved these changes

@justinmc justinmc Awaiting requested review from justinmc

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loic-sharma @hellohuanlin