Add flag to ThemeData to expand tap targets of certain material widgets #18369

jonahwilliams · 2018-06-11T19:28:47Z

Adds a new ThemeData property called materialTapTargetSize which configures minimum tap targets

Defaults to MaterialTapTargetSize.padded.

Increase size of checkbox, switch, and radio button to 48 by 48
Increase material button minimum tap target height to 48
Increase chip minimum height to 48.
update chip tap areas to be more forgiving

The previous size can be obtained using MaterialTapTargetSize.shrinkWrap, either by providing to theme data or through the new constructor params

Succeeds:

Fixes #615

…_615

…nform to android a11y scanner

jonahwilliams · 2018-06-11T19:29:59Z

Not sure whether we should explicitly call out the changes to each widget on the documentation - If so I would prefer to do that on the PR where the change is made

Hixie · 2018-06-11T19:47:06Z

packages/flutter/lib/src/material/theme_data.dart

@@ -483,6 +488,10 @@ class ThemeData extends Diagnosticable {
  /// Defaults to the current platform.
  final TargetPlatform platform;

+  /// Whether to expand the tap target of certain material widgets to a minimum
+  /// of 48dp by 48dp.
+  final bool expandedTapTargetSize;


This could be an enum or a double, but I don't think it makes sense for it to be a bool.

Hixie · 2018-06-11T19:48:34Z

We shouldn't check this in separate from all the breaking changes that will rely on it. It should all land at the same time. Otherwise we run the risk of people setting the flag and then us changing the behaviour of the flag (especially since tomorrow is the cut-off for the next beta, so there'd likely be a whole cycle between this commit and the one that uses the flag).

jonahwilliams · 2018-06-11T19:50:02Z

I'll go ahead and merge all of the other PRs into this one then.

jonahwilliams · 2018-06-18T19:33:13Z

I have a solution - in the gif below I've increased the padding significantly and I tap below, inside of, then above the button. If the "_RedirectingHitDetectionWidget " I added in button is reasonable, I can move it to material so i can reuse it for chips as well.

jonahwilliams · 2018-06-19T16:52:43Z

I guess chip changes are still TBD for chips with two actions, but it will likely require splitting a chip into two tap targets.

Hixie · 2018-06-19T17:12:59Z

packages/flutter/lib/src/material/button.dart

+      return false;
+    return child.hitTest(result, position: size.center(Offset.zero));
+  }
+}


this is an interesting approach.

Why can't we just make the single GestureDetector bigger though?

The GestureDetector/InkWell/Material is a delicate ecosystem.

InkWell (which contains the gesture detector) uses context to find a parent material where it draws the splashes. Any increase in the size of the gesture detector, which is sized by the material, necessarily increase the material size which would increase the visible appearance of the button.

Oh, right, I forgot that buttons had their own Material...

Please add a test to make sure that only one of the GestureDetectors gets the pointer down event (which I believe this code does as you wrote it but it's something we should make sure we don't regress since it's so subtle).

Also please make sure there's a test that when you tap inside the button, the splash starts where you tapped, but when you tap outside the button, it starts wherever we decided it should start.

Hixie · 2018-06-19T17:22:43Z

packages/flutter/lib/src/material/button.dart

+/// The primary purpose of this widget is to allow padding around [Material] widgets
+/// to trigger the child ink feature without increasing the size of the material.
+class _RedirectingHitDetectionWidget extends SingleChildRenderObjectWidget {
+  const _RedirectingHitDetectionWidget({this.constraints, Widget child}) : super(child: child);


widgets should always take keys

Hixie · 2018-06-19T17:23:11Z

packages/flutter/lib/src/material/button.dart

+
+  @override
+  RenderObject createRenderObject(BuildContext context) {
+    return _RedirectingHitDetectionRenderObject(constraints);


we should still have a new until we have the lint that prevents us from using new

Hixie · 2018-06-19T17:23:38Z

packages/flutter/lib/src/material/button.dart

+  }
+}
+
+class _RedirectingHitDetectionRenderObject extends RenderConstrainedBox {


convention for naming these is "RenderFoo", with the widget being called "Foo".

jonahwilliams · 2018-06-19T22:49:34Z

Still need to expand test coverage for the new hit detection behaviors

jonahwilliams · 2018-06-25T17:32:08Z

I've added test cases to cover the new material button ink behavior and the expanded hit area of chips, PTAL

jonahwilliams · 2018-07-02T22:17:06Z

Friendly ping @goderbauer , @Hixie

goderbauer · 2018-07-03T16:43:14Z

Can you update the PR description? Looks like the PRs mentioned there have been merged into this one?

jonahwilliams · 2018-07-03T16:48:29Z

Done

goderbauer

LGTM

Did we announce this as a breaking change already?

jonahwilliams · 2018-07-03T16:54:26Z

Yes, I will make sure to send a follow-up announcement

…target_flag

…al widgets (#18369)" This reverts commit 989f574.

…al widgets (#18369)" (#19053) This reverts commit 989f574.

jonahwilliams and others added 18 commits May 25, 2018 16:31

add semantic container, selectability, and enabled state to chip

39cd943

add tests for chip semantics

cf8a1c3

Merge branch 'master' of github.com:flutter/flutter into a11y_16964

07d5e9b

add more test coverage, make sure hasEnabledState is present

42402a1

update tests and use canTap

be5801f

increase tap target using outer padding

ef41d7f

changed outer padding to outer constraints, update some tests

2a9a87e

increase time picker height by 12dp to account for bigger flat button

5a90a0e

Update button.dart

cdabb2e

adjust minimum heights of other buttons and fix some tests

d8a89ca

Merge branch 'a11y_615' of github.com:jonahwilliams/flutter into a11y…

423a093

…_615

temporarily turn off two failing tests

985fdb6

Merge branch 'master' of github.com:flutter/flutter into a11y_16964

5944354

increase minimum touch target to 48x48

6e79412

make outer constraints configurable

c3fbe84

increase size of checkbox, switch, and radio button to 48 by 48 to co…

21c2941

…nform to android a11y scanner

add flag for expanding tap targets

d412128

add smoke test for tap target size

4bf34be

jonahwilliams requested review from Hixie and goderbauer June 11, 2018 19:28

googlebot added the cla: yes label Jun 11, 2018

Hixie reviewed Jun 11, 2018

View reviewed changes

jonahwilliams added 3 commits June 11, 2018 13:00

switch flag for enum

61c6e30

merge a11y_615 into flag change

8a3f125

merge material button tap target changes adjusted to use new flag

7bb9ff9

jonahwilliams mentioned this pull request Jun 11, 2018

Increase material button minimum tap target height to 48dp #18048

Closed

Merge branch 'a11y_16964' into tap_target_flag

3bf7bcf

merge with remote

5f475d8

Hixie reviewed Jun 19, 2018

View reviewed changes

jonahwilliams added 2 commits June 19, 2018 13:57

Address comments

7e61552

increase chip hit detection and address button comments

190be7b

jonahwilliams added 2 commits June 21, 2018 21:44

Add ink tests for raw material button

df92deb

add tests for material chip behavior

0145ffb

goderbauer approved these changes Jul 3, 2018

View reviewed changes

Merge branch 'master' of https://github.com/flutter/flutter into tap_…

fea5961

…target_flag

jonahwilliams merged commit 989f574 into flutter:master Jul 3, 2018

jonahwilliams deleted the tap_target_flag branch July 3, 2018 17:56

jonahwilliams restored the tap_target_flag branch July 3, 2018 20:42

jonahwilliams deleted the tap_target_flag branch July 3, 2018 20:42

jonahwilliams restored the tap_target_flag branch July 3, 2018 20:42

jonahwilliams added a commit that referenced this pull request Jul 3, 2018

Revert "Add flag to ThemeData to expand tap targets of certain materi…

2140672

…al widgets (#18369)" This reverts commit 989f574.

jonahwilliams mentioned this pull request Jul 3, 2018

Revert "Add flag to ThemeData to expand tap targets of certain material widgets" #19053

Merged

jonahwilliams added a commit that referenced this pull request Jul 3, 2018

Revert "Add flag to ThemeData to expand tap targets of certain materi…

cabe09a

…al widgets (#18369)" (#19053) This reverts commit 989f574.

jonahwilliams added a commit that referenced this pull request Jul 9, 2018

Re-land #18369 (#19082)

77a528c

alardizabal mentioned this pull request Jul 10, 2018

Splash doesn't cover entire widget #19212

Closed

github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add flag to ThemeData to expand tap targets of certain material widgets #18369

Add flag to ThemeData to expand tap targets of certain material widgets #18369

jonahwilliams commented Jun 11, 2018 •

edited

Loading

jonahwilliams commented Jun 11, 2018

Hixie Jun 11, 2018

Hixie commented Jun 11, 2018

jonahwilliams commented Jun 11, 2018

jonahwilliams commented Jun 18, 2018 •

edited

Loading

jonahwilliams commented Jun 19, 2018

Hixie Jun 19, 2018

jonahwilliams Jun 19, 2018

Hixie Jun 19, 2018

Hixie Jun 19, 2018

jonahwilliams Jun 19, 2018

Hixie Jun 19, 2018

jonahwilliams Jun 19, 2018

Hixie Jun 19, 2018

jonahwilliams Jun 19, 2018

jonahwilliams commented Jun 19, 2018

jonahwilliams commented Jun 25, 2018

jonahwilliams commented Jul 2, 2018

goderbauer commented Jul 3, 2018

jonahwilliams commented Jul 3, 2018

goderbauer left a comment

jonahwilliams commented Jul 3, 2018

Add flag to ThemeData to expand tap targets of certain material widgets #18369

Add flag to ThemeData to expand tap targets of certain material widgets #18369

Conversation

jonahwilliams commented Jun 11, 2018 • edited Loading

jonahwilliams commented Jun 11, 2018

Choose a reason for hiding this comment

Hixie commented Jun 11, 2018

jonahwilliams commented Jun 11, 2018

jonahwilliams commented Jun 18, 2018 • edited Loading

jonahwilliams commented Jun 19, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonahwilliams commented Jun 19, 2018

jonahwilliams commented Jun 25, 2018

jonahwilliams commented Jul 2, 2018

goderbauer commented Jul 3, 2018

jonahwilliams commented Jul 3, 2018

goderbauer left a comment

Choose a reason for hiding this comment

jonahwilliams commented Jul 3, 2018

jonahwilliams commented Jun 11, 2018 •

edited

Loading

jonahwilliams commented Jun 18, 2018 •

edited

Loading