Re-land #18369 #19082
Merged
Re-land #18369 #19082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nform to android a11y scanner
…Radio, and Switch
…s an optional input
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cause of the test failure was in my redirect hit test logic. If the hit test would have hit the child anyway, then moving the offset to the center could cause the test to fail if the child is off center. This manifested in the gallery test not being able to tap on a category since the finder used the text value, which was below the center of the button.
I've corrected this logic and added new test cases to confirm that it works correctly, and verified with the device lab test locally