Thanks to visit codestin.com
Credit goes to github.com

Skip to content

prepare for lint update of prefer_final_fields #35059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2019
Merged

prepare for lint update of prefer_final_fields #35059

merged 1 commit into from
Jun 25, 2019

Conversation

a14n
Copy link
Contributor

@a14n a14n commented Jun 25, 2019

Description

update for the upcoming prefer_final_fields changes.

Related Issues

Fixes dart-lang/sdk#57985

Tests

None

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@a14n a14n requested review from pq and dnfield June 25, 2019 15:47
pq
pq approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You beat me to it!

Fantastic. Thanks! 👍

@a14n a14n merged commit c7408be into flutter:master Jun 25, 2019
@a14n a14n deleted the update-lint-prefer_final_fields branch June 25, 2019 17:39
@pq pq mentioned this pull request Jun 25, 2019
Closed
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@a14n @johnsonmh
prepare for lint update of prefer_final_fields (flutter#35059)
3d32825
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pq pq pq approved these changes

@dnfield dnfield dnfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update potentially final fields for Flutter (blocking 0.1.92)
4 participants
@a14n @pq @dnfield @googlebot