Revert Optimize transformRect #37049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix_utils. (flutter#36396)" This reverts commit 9946f7c.
tvolkert
approved these changes
Jul 26, 2019
|
(It turns out the addition is correct - we just need to handle cases like this in the optimized method) |
|
What was the use case where this happened? |
|
Test on an google internal app - I'll try to get you a reproduction. Basically, the semantics rect comes out with these values and wants to get transformed and then fails. |
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
* Revert "Optimize the transformRect and transformPoint methods in matrix_utils. (flutter#36396)" This reverts commit 9946f7c. * add test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new implementation results in a non-finite rect when using very small values for the rect bounds. I'm a bit surprised by this -
1.7976931348623157e+308 - -1.7976931348623157e+308is evaluating todouble.infinity, which seems like a bug but I might be missing some finer point of IEEE 754.Added a test to make sure that when we reland the optimized version we don't regress this again.