Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use relative paths when installing module pods #37738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2019
Merged

Use relative paths when installing module pods #37738

merged 1 commit into from
Aug 7, 2019

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Aug 7, 2019

Description

Use relative paths to install pods to allow versioning of Podfile.lock.

Related Issues

Fixes #37734
See also #9502

Tests

Made sure module_test_ios still passed.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. a: existing-apps Integration with existing apps via the add-to-app flow labels Aug 7, 2019
@jmagman jmagman added this to the August 2019 milestone Aug 7, 2019
@jmagman jmagman requested a review from xster August 7, 2019 00:49
@jmagman jmagman self-assigned this Aug 7, 2019
@xster
Copy link
Member

xster commented Aug 7, 2019

LGTM, awesome

@jmagman jmagman merged commit e6d94ee into flutter:master Aug 7, 2019
@jmagman jmagman deleted the podfile-lock branch August 8, 2019 19:30
@Kila2
Copy link

Kila2 commented Aug 14, 2019 •
edited
Loading

Oh no. There has a bug. with __dir__ . if use a module will always failed

Generated.xcconfig must exist. Make sure `flutter pub get` is executed in the Flutter module.

@jmagman
Copy link
Member Author

jmagman commented Aug 14, 2019 •
edited
Loading

Oh no. There has a bug. with dir . if use a module will always failed

Generated.xcconfig must exist. Make sure `flutter pub get` is executed in the Flutter module.

@Kila2 can you file an issue and @ me?

@Kila2
Copy link

Kila2 commented Aug 16, 2019

Oh no. There has a bug. with dir . if use a module will always failed

Generated.xcconfig must exist. Make sure `flutter pub get` is executed in the Flutter module.

@Kila2 can you file an issue and @ me?
I forget set

eval(File.read(File.join(flutter_application_path, '.ios', 'Flutter', 'podhelper.rb')), binding)

to

load File.join(flutter_application_path, '.ios', 'Flutter', 'podhelper.rb')

it's work fine

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xster xster Awaiting requested review from xster

Assignees

@jmagman jmagman

Labels
a: existing-apps Integration with existing apps via the add-to-app flow platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
August 2019
Development

Successfully merging this pull request may close these issues.

Module Podfile.lock contains absolute paths
4 participants
@jmagman @xster @Kila2 @googlebot