Add web workflow to default validators #39006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
reviewed
Aug 21, 2019
| @@ -845,3 +859,4 @@ class VsCodeValidatorTestTargets extends VsCodeValidator { | |||
| } | |||
|
|
|||
| class MockProcessManager extends Mock implements ProcessManager {} | |||
| class MockPlatform extends Mock implements Platform {} | |||
Codecov Report
@@ Coverage Diff @@
## master #39006 +/- ##
==========================================
+ Coverage 55.41% 56.42% +1.01%
==========================================
Files 195 195
Lines 18345 18294 -51
==========================================
+ Hits 10165 10322 +157
+ Misses 8180 7972 -208
Continue to review full report at Codecov.
|
zanderso
approved these changes
Aug 22, 2019
| @@ -113,6 +113,9 @@ class _DefaultDoctorValidatorsProvider implements DoctorValidatorsProvider { | |||
| if (windowsWorkflow.appliesToHostPlatform) | |||
| _workflows.add(windowsWorkflow); | |||
|
|
|||
| if (webWorkflow.appliesToHostPlatform) | |||
There was a problem hiding this comment.
(optional, nit) switch to new syntax.
return _workflows ??= <Workflow>[
if (iosWorkflow.appliesToHostPlatform) iosWorkflow,
if (androidWorkflow.appliesToHostPlatform) androidWorkflow,
...
];There was a problem hiding this comment.
Worth doing, but there are some timing constraints with this fix...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The WebWorkflow was missing from the doctor validators. This would prevent a user that has an available "web device" from running flutter if they didn't have any other functioning devices.
Discovered by @natebosch