Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix englishLike2018 bodyText #49756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2020
Merged

Fix englishLike2018 bodyText #49756

merged 1 commit into from
Mar 6, 2020

Conversation

mono0926
Copy link
Contributor

@mono0926 mono0926 commented Jan 30, 2020 •
edited
Loading

Description

It seems that fontSize and letterSpacing of englishLike2018's bodyText1 and bodyText2 is opposite, so I fixed it.

Current (Seems to be wrong)

category fontSize letterSpacing
bodyText1 14 0.25
bodyText2 16 0.5

Material Design Spec

category fontSize letterSpacing
bodyText1 16 0.5
bodyText2 14 0.25

mio-staging-mio-design-1579302979877-assets-1W8kyGVruuG_O8psvyiOaCf1lLFIMzB-N-typesystem-typescale
https://material.io/design/typography/the-type-system.html

I changed fontSize and letterSpacing to latter from former.

Related Issues

Tests

None, but the test under packages/flutter/test succeeded.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

#48547 released as v1.14.6, so the user who uses new englishLike2018's bodyText1 and bodyText2 affected, but they are too rare.

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. work in progress; do not review labels Jan 30, 2020
@mono0926 mono0926 marked this pull request as ready for review January 30, 2020 01:21
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@mono0926
Copy link
Contributor Author

I'd like to remove work in progress; do not review label, because I changed to ready for review from Draft.

@mono0926 mono0926 requested a review from HansMuller January 30, 2020 02:58
@HansMuller
Copy link
Contributor

This is a good change however it may break existing tests. Checking the internal test repo now.

@roman-petrov roman-petrov mentioned this pull request Feb 3, 2020
Closed
@HansMuller HansMuller mentioned this pull request Mar 6, 2020
Closed
9 tasks
@HansMuller
Copy link
Contributor

I've checked the tests in our local repo and, to my surprise, all appears to be well. Will attempt to land this change now.

@HansMuller HansMuller merged commit 2294d75 into flutter:master Mar 6, 2020
@mono0926 mono0926 deleted the fix-englishLike2018-bodyText branch March 7, 2020 00:05
mono0926 added a commit to mono0926/flutter_mono_kit that referenced this pull request Mar 7, 2020
@mono0926
Remove Typography.material2018() workaround
24a58dc 
- flutter/flutter#49756 was merged.
@Piinks Piinks mentioned this pull request Mar 18, 2020
Closed
10 tasks
@HansMuller HansMuller mentioned this pull request Jun 5, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HansMuller HansMuller HansMuller approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mono0926 @fluttergithubbot @HansMuller @googlebot @jonahwilliams