Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Teach flutter init how to depend on flutter using a relative path #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2015
Merged

Teach flutter init how to depend on flutter using a relative path #51

merged 1 commit into from
Nov 8, 2015

Conversation

abarth
Copy link
Contributor

@abarth abarth commented Nov 7, 2015

No description provided.

@abarth
Copy link
Contributor Author

abarth commented Nov 7, 2015

@devoncarew

devoncarew
devoncarew reviewed Nov 8, 2015
View reviewed changes
packages/flutter_tools/lib/src/artifacts.dart
@@ -155,6 +156,7 @@ class ArtifactStore {
return null;
}

static String flutterRoot;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe note that these are inited on startup from FlutterCommandRunner?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Having these in statics is kind of wonky. I bet there's a better way to do it.

@devoncarew
Copy link
Member

lgtm! We'll need to update docs to clarify how users should get getting the flutter repo and setting up env. variables and such.

@abarth
Copy link
Contributor Author

abarth commented Nov 8, 2015

We'll need to update docs to clarify how users should get getting the flutter repo and setting up env. variables and such.

The end-user won't need to set up any env variables. The bin/flutter script sets up everything by looking at its own path in the file system. It actually does all the work of running pub on flutter_tools and compiling the snapshot, etc. Eventually it will also pull down a copy of the Dart SDK so that the "getting started" instructions will just be:

  1. Clone the repo
  2. Run flutter init -o my_project

abarth added a commit that referenced this pull request Nov 8, 2015
@abarth
Merge pull request #51 from abarth/init_from_path
9bc6e68 
Teach flutter init how to depend on flutter using a relative path
@abarth abarth merged commit 9bc6e68 into flutter:master Nov 8, 2015
@abarth abarth deleted the init_from_path branch November 8, 2015 05:36
@mpcomplete mpcomplete mentioned this pull request Apr 20, 2016
Closed
@mpcomplete mpcomplete mentioned this pull request Jun 17, 2016
Closed
@jason-simmons jason-simmons mentioned this pull request Jul 21, 2016
Closed
@mswift42 mswift42 mentioned this pull request Nov 13, 2016
Closed
@gavindoughtie gavindoughtie mentioned this pull request Dec 2, 2016
Closed
@rantianhua rantianhua mentioned this pull request Jan 13, 2017
Closed
@Reagankm Reagankm mentioned this pull request Jan 19, 2017
Closed
@ppolasek ppolasek mentioned this pull request Feb 8, 2017
Closed
@skybrian skybrian mentioned this pull request Feb 16, 2017
Closed
@Reagankm Reagankm mentioned this pull request Feb 24, 2017
Closed
@collinjackson collinjackson mentioned this pull request May 19, 2017
Closed
@jamesgopinath jamesgopinath mentioned this pull request Aug 4, 2017
Closed
@apwilson apwilson mentioned this pull request Aug 10, 2017
Closed
@JFixby JFixby mentioned this pull request Sep 7, 2017
Closed
@DaveShuckerow DaveShuckerow mentioned this pull request Sep 18, 2017
Closed
@gavindoughtie gavindoughtie mentioned this pull request Sep 25, 2017
Closed
@arnold-nonstop arnold-nonstop mentioned this pull request Sep 29, 2017
Closed
@amirh amirh mentioned this pull request Oct 9, 2017
Closed
@Tony-Akani Tony-Akani mentioned this pull request Nov 1, 2020
Closed
@kw2019ltd kw2019ltd mentioned this pull request Nov 16, 2020
Closed
@page-bunnii page-bunnii mentioned this pull request Nov 20, 2020
Closed
@issantech issantech mentioned this pull request Nov 23, 2020
Closed
@RobynKing88 RobynKing88 mentioned this pull request Dec 6, 2020
Closed
This was referenced Dec 11, 2020
Closed
Closed
@sureace sureace mentioned this pull request Jan 13, 2021
Closed
@staminna staminna mentioned this pull request Jan 22, 2021
Closed
@yannainghtun-mk yannainghtun-mk mentioned this pull request Jan 26, 2021
Closed
@1005274291 1005274291 mentioned this pull request Jan 26, 2021
Closed
@praneethpj praneethpj mentioned this pull request Jan 29, 2021
Closed
@sravanpabolu sravanpabolu mentioned this pull request Feb 11, 2021
Closed
@lianchengtong lianchengtong mentioned this pull request Feb 13, 2021
Closed
@PiechKevin PiechKevin mentioned this pull request Feb 14, 2021
Closed
@hannahgrinton hannahgrinton mentioned this pull request Feb 24, 2021
Closed
@Marko1994 Marko1994 mentioned this pull request Mar 4, 2021
Closed
@lironzemingo lironzemingo mentioned this pull request Mar 11, 2021
Closed
@xox9001 xox9001 mentioned this pull request Mar 24, 2021
Closed
@deCardenas deCardenas mentioned this pull request Apr 10, 2021
Closed
@bladeofgod bladeofgod mentioned this pull request Apr 14, 2021
Open
@sauravgpt sauravgpt mentioned this pull request Apr 28, 2021
Closed
@imeDevelopers imeDevelopers mentioned this pull request May 5, 2021
Closed
@naveedrehman90001 naveedrehman90001 mentioned this pull request May 6, 2021
Closed
@SlowGen SlowGen mentioned this pull request May 27, 2021
Closed
@Dalimar95 Dalimar95 mentioned this pull request Jun 8, 2021
Closed
@akashgk akashgk mentioned this pull request Jun 18, 2021
Closed
@SamStrike0809 SamStrike0809 mentioned this pull request Jun 18, 2021
Closed
@94wogus 94wogus mentioned this pull request Jul 3, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abarth @devoncarew