Thanks to visit codestin.com
Credit goes to github.com

Skip to content

support older android devices (>= 17) #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2015

Conversation

devoncarew
Copy link
Member

  • fix regex adb devices -l parsing for older android devices
  • move the version check back to android 17 (4.2.x of Jelly Bean) - I loaded up a few flutter sample apps on a v17 device
  • re-word the error message for older devices, so that it identifies the device version as the issue, instead of the android sdk version

Flutter didn't load successfully on the v15 device I have (ICS). I didn't test on the first version of Jelly Bean (v16, 4.1.0). So:

  • v15: crash
  • v16: ??
  • v17: success

@devoncarew
Copy link
Member Author

@abarth

The v17 device did complain to logcat about some font metadata paths:

android: I/chromium: [INFO:SkFontMgr_android_parser.cpp(595)] [SkFontMgr Android Parser] '/system/etc/fonts.xml' could not be opened
android: I/chromium: [INFO:SkFontMgr_android_parser.cpp(595)] [SkFontMgr Android Parser] '/vendor/etc/fallback_fonts.xml' could not be opened

but seemed to run fine. From adb shell ls, those font files didn't exist on the 4.2.1 device, but these files did:

[~/projects/flutter/flutter/packages/flutter_tools] adb shell ls -l /system/etc/system_fonts.xml
-rw-r--r-- root     root         3418 2012-11-16 16:28 system_fonts.xml
[~/projects/flutter/flutter/packages/flutter_tools] adb shell ls -l /system/etc/fallback_fonts.xml
-rw-r--r-- root     root         4153 2012-11-16 16:28 fallback_fonts.xml

@sethladd
Copy link
Contributor

sethladd commented Nov 8, 2015

FWIW we state in a few places that we support KitKat and up. Perhaps we should be a bit more specific and state which version numbers and API levels we support: https://source.android.com/source/build-numbers.html

I'll open an issue for the site.

@devoncarew
Copy link
Member Author

Related to the link mapping versions and api levels, here's one that has usage levels for the various android versions: http://developer.android.com/about/dashboards/index.html.

@abarth
Copy link
Contributor

abarth commented Nov 8, 2015

v15 device I have (ICS)

One of the core Android framework components we use (Choreographer) doesn't exist on ICS. We can write a replacement for it if we need it. Chrome has a replacement that we can use as a model. We should be able to run on even the earliest release of JB.

@@ -0,0 +1 @@
lib/cache/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't actually need this once my patch lands. I'm moving the cache up to //bin/cache to share with everything else.

@abarth
Copy link
Contributor

abarth commented Nov 8, 2015

LGTM

@devoncarew
Copy link
Member Author

Cool, updated to specify all Jelly Bean versions (android >= v16).

devoncarew added a commit that referenced this pull request Nov 8, 2015
support older android devices (>= 17)
@devoncarew devoncarew merged commit 4112f66 into flutter:master Nov 8, 2015
@peterwilli
Copy link

@abarth Hi, you mentioned One of the core Android framework components we use (Choreographer) doesn't exist on ICS. We can write a replacement for it if we need it. Chrome has a replacement that we can use as a model.

I really need to get React-Native (sorry for mentioning competing framework) to work with Android ICS and am trying to make it work with that.

Could you point me to the Choreographer implementation in the chromium source, so I can continue on my humble quest? Thanks!

@abarth
Copy link
Contributor

abarth commented Apr 12, 2016

It looks like they might have removed the code. I'd try digging into the history of https://code.google.com/p/chromium/codesearch#chromium/src/ui/android/java/src/org/chromium/ui/VSyncMonitor.java to see what the code used to do.

@peterwilli
Copy link

@abarth wow fast reply, thanks! Doesn't surprise me they dropped it, since they cancelled android ICS support back in 2015. That's why I wasn't able to find it :) Thanks again!

Update: In case anyone wants this too, ICS compatibillity was removed here: https://chromium.googlesource.com/chromium/src/+/962fc2256d7dd6c8ade0c13b3fbefb4a524b8a4c%5E%21/

I'll check this out tomorrow.

@Reagankm Reagankm mentioned this pull request Jan 19, 2017
@akashgk akashgk mentioned this pull request Jun 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants