It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

I've updated the test, but please check the following:

• I'm pulling the application ID out of my_application.cc. This feels a bit hacky, so not sure if we want to move this into a more common location, e.g. CMakeLists.txt?
• By requiring the test to run with Linux support, does this make it harder to run elsewhere? Should it be split out from the Android/iOS code?
• I couldn't work out how to run the tests locally, so I'm relying on the CI system to have run them correctly.

Started Google testing for this PR

• I'm pulling the application ID out of my_application.cc. This feels a bit hacky, so not sure if we want to move this into a more common location, e.g. CMakeLists.txt?

That would make the parsing less subject to accidental breakage. Probably worth doing in case this code gets used in production, rather than just tests.

• By requiring the test to run with Linux support, does this make it harder to run elsewhere? Should it be split out from the Android/iOS code?

No, that's just the mock context; it'll run everywhere.

• I couldn't work out how to run the tests locally, so I'm relying on the CI system to have run them correctly.

cd packages/flutter_tools
pub get
pub run test <relative path to test file>

Or if you use VS Code with the Flutter extension, you'll get an affordance to run individual tests from the UI.

Google testing passed!

I wasted far too much time trying to debug that regexp 🤯...

@stuartmorgan, can you have a quick look and see if the CMake changes look good to you. The only other thing I was thinking is the application ID is coded into both the CMakeLists.txt and my_application.cc - we could use a define/generated header to pass that variable through. I'm not sure what your preferred method of doing is that with CMake or if it really matters.

The only other thing I was thinking is the application ID is coded into both the CMakeLists.txt and my_application.cc - we could use a define/generated header to pass that variable through. I'm not sure what your preferred method of doing is that with CMake or if it really matters.

A define should work fine, and would be much simpler than a generated header, so that SGTM. I do think we shouldn't have it in two places, as that's a foot-gun.