Derive colors demo TextStyle from theme #6632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abarth
reviewed
Nov 1, 2016
| @@ -79,11 +79,11 @@ class ColorSwatchTabView extends StatelessWidget { | |||
| } | |||
|
|
|||
| final ColorSwatch swatch; | |||
| final TextStyle blackTextStyle = Typography.black.body1; | |||
| final TextStyle whiteTextStyle = Typography.white.body1; | |||
There was a problem hiding this comment.
We should consider removing these statics. They seem to be a big footgun.
There was a problem hiding this comment.
+1! I've actually got a patch coming up right after this one to do just that :)
|
|
This was referenced Oct 22, 2018
engine-flutter-autoroll
pushed a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 23, 2018
(flutter#23417) cdd592f Reland 'Pass null instead of 'none' locale' (flutter#6632) 2cd8920 Roll src/third_party/skia b1a002e850e1..327955b1ba19 (12 commits) (flutter#6631) edfe024 13771 - iOS dictation bug (flutter#6607) cadf440 Roll src/third_party/skia b9998cdceec7..b1a002e850e1 (13 commits) (flutter#6626)
Xavjer
pushed a commit
to Xavjer/flutter
that referenced
this pull request
Oct 24, 2018
(flutter#23417) cdd592f Reland 'Pass null instead of 'none' locale' (flutter#6632) 2cd8920 Roll src/third_party/skia b1a002e850e1..327955b1ba19 (12 commits) (flutter#6631) edfe024 13771 - iOS dictation bug (flutter#6607) cadf440 Roll src/third_party/skia b9998cdceec7..b1a002e850e1 (13 commits) (flutter#6626)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.