Only synchronize used Dart sources to DevFS. #6668
Conversation
johnmccutchan
commented
Nov 2, 2016
- Remove the second full-sync on startup.
- Always invoke the snapshotter to determine the minimal set of Dart sources used.
- Only synchronize the used Dart sources to DevFS.
- Detect syntax / file missing errors on the host and gate reloads / restarts.
|
This needs a roll of the engine too but the bots are red, so, I'm putting this up for review in the meantime. |
| /// Run cmd and return stdout on success. | ||
| /// | ||
| /// Throws the standard error output if cmd exits with a non-zero value. | ||
| String runSyncAndThrowStdErrOnError(List<String> cmd) { |
There was a problem hiding this comment.
we really should avoid adding more ways to run subprocesses... I don't suppose I can get you to embrace a yak shave that involves cleaning up this file, can I? :-)
There was a problem hiding this comment.
Agreed but I'm thinking more about instance field initializers...
| /// Run cmd and return stdout on success. | ||
| /// | ||
| /// Throws the standard error output if cmd exits with a non-zero value. | ||
| String runSyncAndThrowStdErrOnError(List<String> cmd) { |
There was a problem hiding this comment.
We should probably move away from "Sync" ways of running subprocesses, by the way, since they block progress meters.
| } catch (e) { | ||
| return null; | ||
| rethrow; |
There was a problem hiding this comment.
Dropped the try { } catch {}.
| result = await _restartFromSources(); | ||
| } | ||
| if (!result.isOk) { | ||
| printStatus('Try again after fixing the above error(s).', emphasis: true); |
There was a problem hiding this comment.
Bonus points if you can figure out how many errors there were, and use error/errors appropriately instead of "error(s)". :-)
There was a problem hiding this comment.
Line count might be sufficient. I've added a TODO here.
| bool updatedDevFS = await _updateDevFS(); | ||
| if (!updatedDevFS) { | ||
| return new OperationResult(1, 'Dart Source Error'); | ||
| } |
| if (_devFS != null) { | ||
| bool updatedDevFS = await _updateDevFS(); | ||
| if (!updatedDevFS) { | ||
| return new OperationResult(1, 'Dart Source Error'); |
|
LGTM with comments |
- [x] Remove the second full-sync on startup. - [x] Always invoke the snapshotter to determine the minimal set of Dart sources used. - [x] Only synchronize the *used* Dart sources to DevFS. - [x] Detect syntax / file missing errors on the host and gate reloads / restarts.