Search bar dark mode contrast #67679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@darrenaustin Let me know if this isn't how the search bar is supposed to be for dark mode. |
darrenaustin
approved these changes
Oct 24, 2020
| @@ -199,7 +199,9 @@ abstract class SearchDelegate<T> { | |||
| final ThemeData theme = Theme.of(context)!; | |||
| assert(theme != null); | |||
| return theme.copyWith( | |||
| primaryColor: Colors.white, | |||
| primaryColor: theme.brightness == Brightness.dark | |||
There was a problem hiding this comment.
This use of primaryColor in dark themes is something that @HansMuller is trying to sort out at the moment, so this may need to change in the future. For now though this is a reasonable fix for this case. At some point this should be migrated to colorScheme colors.
There was a problem hiding this comment.
Got it, thanks for the heads up. Hans, let me know if I should open an issue for this or comment anywhere so it's not missed.
gildaswise
added a commit
to gildaswise/flutter
that referenced
this pull request
Oct 26, 2020
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In dark mode, the search bar was white with white text. Now it looks like this:
Related Issues
Closes #66781
Tests
In both light and dark mode, verify the color of the app bar and text are not the same.