In the semantics tree, do not detach a child if it has already been assigned a new parent #6773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Nov 9, 2016
|
|
||
| void main() { | ||
| testWidgets('Enable semantics', (WidgetTester tester) async { | ||
| RendererBinding.instance.setSemanticsEnabled(true); |
There was a problem hiding this comment.
in theory nothing guarantees the order the tests run in and they shouldn't depend on each other.
I think the right way to factor this out would be to have the inside of the "Flutter Gallery app smoke test" in its own function, and then have the two tests both call that function. The semantics one should enable the semantics before and disable them after. I think it'd be fine for these two tests to be in the same file (otherwise it's a bit weird because one test imports the other).
Hixie
reviewed
Nov 9, 2016
| for (SemanticsNode child in _children) | ||
| child.detach(); | ||
| for (SemanticsNode child in _children) { | ||
| if (child.parent == this) { |
There was a problem hiding this comment.
add a comment saying why this might not be true
|
|
a2424ac to
270c578
Compare
Hixie
reviewed
Nov 10, 2016
| flutter_gallery_main | ||
| .main(); // builds the app and schedules a frame but doesn't trigger one | ||
| Future<Null> runSmokeTest(WidgetTester tester) async { | ||
| await tester.pumpWidget(new GalleryApp()); |
There was a problem hiding this comment.
nit: this is indented 4 instead of 2
Hixie
reviewed
Nov 10, 2016
| for (SemanticsNode child in _children) { | ||
| // The list of children may be stale and may contain nodes that have | ||
| // been assigned to a different parent. | ||
| if (child.parent == this) { |
|
still |
…ssigned a new parent Fixes flutter#6690 Also add a version of the Gallery smoke test that enables semantics
270c578 to
339b320
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6690
Also add a version of the Gallery smoke test that enables semantics