flutter test --start-paused #7584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d310bd to
e0317a6
Compare
tvolkert
reviewed
Jan 23, 2017
| @@ -70,12 +72,13 @@ enum _TestResult { crashed, harnessBailed, testBailed } | |||
| typedef Future<Null> _Finalizer(); | |||
|
|
|||
| class FlutterPlatform extends PlatformPlugin { | |||
| FlutterPlatform({ this.shellPath, this.collector, this.explicitObservatoryPort, this.explicitDiagnosticPort }) { | |||
| FlutterPlatform({ this.shellPath, this.collector, this.debuggerMode, this.explicitObservatoryPort, this.explicitDiagnosticPort }) { | |||
There was a problem hiding this comment.
We should probably make this constructor private
tvolkert
reviewed
Jan 23, 2017
| @@ -51,6 +51,7 @@ final InternetAddress _kHost = InternetAddress.LOOPBACK_IP_V4; | |||
| void installHook({ | |||
| @required String shellPath, | |||
| CoverageCollector collector, | |||
| bool debuggerMode, | |||
|
LGTM |
Make debugging tests in a debugger easier. Fixes flutter#163
e0317a6 to
602faf3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make debugging tests in a debugger easier.
Fixes #163