Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[web] Treeshake keymaps for web (4% code size reduction in hello world)#75945

Merged
fluttergithubbot merged 9 commits into
flutter:masterfrom
ferhatb:treeshake_keymap
Feb 25, 2021
Merged

[web] Treeshake keymaps for web (4% code size reduction in hello world)#75945
fluttergithubbot merged 9 commits into
flutter:masterfrom
ferhatb:treeshake_keymap

Conversation

@ferhatb

@ferhatb ferhatb commented Feb 13, 2021 •
edited by mdebbar
Loading

Copy link
Copy Markdown
Contributor

Remove android/mac and other keymaps from web bundles.

Reduces hello world app size from 881705 to 847524.

#37796

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Feb 13, 2021
@flutter-dashboard

flutter-dashboard Bot commented Feb 13, 2021

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla Bot added the cla: yes label Feb 13, 2021
mdebbar
mdebbar approved these changes Feb 13, 2021
View reviewed changes

@mdebbar mdebbar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me.

@gspencergoog @dkwingsmt there's a PR that moved web key maps to the engine. Is there a plan to do the same for other platforms?

@dkwingsmt

dkwingsmt commented Feb 13, 2021

Copy link
Copy Markdown
Contributor

@mdebbar Yes there is. However we're probably not removing the part in the framework until after a year.

@fluttergithubbot fluttergithubbot merged commit cc9b78f into flutter:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdebbar mdebbar mdebbar approved these changes

@gspencergoog gspencergoog Awaiting requested review from gspencergoog

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ferhatb @dkwingsmt @mdebbar @fluttergithubbot