Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add dart Fix for TextSelectionThemeData #78897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 1, 2021
Merged

Add dart Fix for TextSelectionThemeData #78897

merged 8 commits into from
Apr 1, 2021

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Mar 23, 2021 •
edited
Loading

This adds a dart fix for the deprecated ThemeData.[cursorColor, textSelectionColor, textSelectionHandleColor, useTextSelectionTheme] and migrates them to the appropriate TextSelectionThemeData parameters.

Part of #74908

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 23, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Mar 23, 2021
Piinks
Piinks commented Mar 23, 2021
View reviewed changes
Piinks
Piinks commented Mar 23, 2021
View reviewed changes
@Piinks

This comment has been minimized.

Sign in to view
@Piinks

This comment has been minimized.

Sign in to view
@Piinks Piinks mentioned this pull request Mar 23, 2021
Closed
@Piinks
Copy link
Contributor Author

Piinks commented Mar 23, 2021

Currently blocked on dart-lang/sdk#45439

@Piinks Piinks mentioned this pull request Mar 24, 2021
Closed
@Piinks Piinks changed the title WIP Dart Fix for TextSelectionThemeData Add dart Fix for TextSelectionThemeData Mar 31, 2021
@Piinks Piinks added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Mar 31, 2021
goderbauer
goderbauer approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit ec0b430 into flutter:master Apr 1, 2021
@Piinks Piinks mentioned this pull request Nov 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

@darrenaustin darrenaustin Awaiting requested review from darrenaustin

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Piinks @goderbauer @fluttergithubbot