Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@HansMuller
Copy link
Contributor

@HansMuller HansMuller commented Jun 23, 2021

Deprecate the ThemeData accentIconTheme constructor parameter and the ThemeData copyWith parameters. These changes were inadvertently left out of #81336.

Added a https://flutter.dev/docs/release/breaking-changes/theme-data-accent-properties link to all of the accent color deprecations. This PR incorporates similar changes that were made in #84747 but never landed.

And just FTR: more information about long-removed dependency of FloatingActionButton on accentColor can be found in #48435 and https://flutter.dev/go/remove-fab-accent-theme-dependency.

Fixes #56639
Fixes #84748

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 23, 2021
@google-cla google-cla bot added the cla: yes label Jun 23, 2021
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fluttergithubbot fluttergithubbot merged commit 99220b0 into flutter:master Jun 23, 2021
@HansMuller HansMuller deleted the deprecate_accent_icon_theme branch June 24, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AccentColor deprecation needs link to migration guide Warning logged for deprecated accentIconTheme

3 participants