Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add fixes for ThemeData #86369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 14, 2021
Merged

Add fixes for ThemeData #86369

merged 3 commits into from
Jul 14, 2021

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Jul 13, 2021 •
edited
Loading

This adds flutter/dart fixes for #81336 which deprecated several properties of ThemeData
There is a full migration guide available at https://flutter.dev/docs/release/breaking-changes/theme-data-accent-properties

Part of #74908

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 13, 2021
@google-cla google-cla bot added the cla: yes label Jul 13, 2021
@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. and removed cla: yes labels Jul 13, 2021
@google-cla google-cla bot added the cla: yes label Jul 13, 2021
@Piinks Piinks added c: tech-debt Technical debt, code quality, testing, etc. and removed cla: yes labels Jul 13, 2021
@google-cla google-cla bot added the cla: yes label Jul 13, 2021
@Piinks Piinks requested review from goderbauer and HansMuller July 13, 2021 18:42
HansMuller
HansMuller reviewed Jul 13, 2021
View reviewed changes
@Piinks
Copy link
Contributor Author

Piinks commented Jul 13, 2021

@HansMuller PTAL. :)

HansMuller
HansMuller approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 252f6a0 into flutter:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Piinks @HansMuller @fluttergithubbot