Deferred components integration test app #88030

GaryQian · 2021-08-11T10:34:57Z

This adds a deferred components integration test app that uses flutter drive to test framework side deferred components loading and a bash script to build and install a split app.

Files of interest for reviewers: test_driver/main_test.dart, run_release_test.sh, lib/main.dart

Replaces the flaky test mentioned in #72312

skia-gold · 2021-08-11T10:44:23Z

Gold has detected about 6 new digest(s) on patchset 2.
View them at https://flutter-gold.skia.org/cl/github/88030

skia-gold · 2021-08-11T19:34:23Z

Gold has detected about 2 new digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/88030

skia-gold · 2021-08-11T19:54:25Z

Gold has detected about 6 new digest(s) on patchset 4.
View them at https://flutter-gold.skia.org/cl/github/88030

blasten · 2021-08-12T19:45:34Z

it would need to remove the binary files

blasten · 2021-08-13T01:45:25Z

dev/integration_tests/deferred_components_test/android/build.gradle

+subprojects {
+    project.buildDir = "${rootProject.buildDir}/${project.name}"
+}
+subprojects {
+    project.evaluationDependsOn(':app')
+}


Suggested change

subprojects {

project.buildDir = "${rootProject.buildDir}/${project.name}"

}

subprojects {

project.evaluationDependsOn(':app')

}

subprojects {

project.buildDir = "${rootProject.buildDir}/${project.name}"

project.evaluationDependsOn(':app')

}

we should probably fix this in the template

Ahh, I think this is just some bad file merging on my end. Templates seem fine.

blasten · 2021-08-13T02:10:14Z

dev/integration_tests/deferred_components_test/run_release_test.sh

@@ -0,0 +1,26 @@
+#!/usr/bin/env bash


any thoughts about using Dart for this, similar to some of the other integration tests? For example:
https://github.com/flutter/flutter/blob/master/dev/devicelab/lib/tasks/dart_plugin_registry_tests.dart#L156

Only one of the commands is a flutter build command, everything else is a mix of adb, bundletool, etc. I think a shell script may be clearer and more concise for now at least.

blasten · 2021-08-13T02:13:37Z

dev/integration_tests/deferred_components_test/android/build.gradle

@@ -0,0 +1,35 @@
+// Copyright 2014 The Flutter Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.


could it use dev/tools/bin/generate_gradle_lockfiles.dar to generate this file as well as the .lockfile?

here's how to use it: https://github.com/flutter/flutter/blob/master/dev/tools/bin/generate_gradle_lockfiles.dart#L16-L19

It looks like that script actually creates both the settings.gradle and build.gradle. Though some of it may be useful, it does generate files that do not implement some of the config needed for deferred components.

Actually, I think I need to go in and add a skip to make sure it doesn't produce incompatible configs for deferred components.

The script could skip overriding settings.gradle.

I'm mostly concerned about the lockfiles since those help to keep transient dependencies consistent between builds.

Ok, I changed to skip settings.gradle. build.gradle is generated now and lockfiles are in.

blasten · 2021-08-13T02:15:28Z

dev/integration_tests/deferred_components_test/lib/component1.dart

+        color: Colors.blue,
+      );
+   }
+}


nit: a new line at the end of file

blasten · 2021-08-13T02:17:34Z

dev/integration_tests/deferred_components_test/lib/component1.dart

+
+  @override
+  Widget build(BuildContext context) {
+    print('Running deferred code');


minor: could this be a named constant? something like testSentinel='Running deferred code'

blasten · 2021-08-13T02:18:15Z

👏 awesome! just some minor comments

blasten

LGTM

Could we use the Android emulators you added on LUCI to test apps like this?

blasten · 2021-08-13T23:34:00Z

dev/integration_tests/deferred_components_test/run_release_test.sh

+sleep 12
+exit
+"
+adb logcat -d -s "flutter" > build/app/outputs/bundle/release/run_logcat.log


this works if we are using android emulators with -wipe-data or if there's nothing cached between CI runs. Do you know if this would be the case?

e.g. consider the case where job 1 runs, then job 2 runs and sees the same log line from job 1.

I'll go find out :)

Added filters/timestamping to ensure only the latest run's logs are tracked.

GaryQian · 2021-08-14T05:12:27Z

Could we use the Android emulators you added on LUCI to test apps like this?

Yes, that is the primary reason why I am writing this test app.

blasten · 2021-08-14T05:32:37Z

Awesome! 🎉

flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Aug 11, 2021

google-cla bot added the cla: yes label Aug 11, 2021

GaryQian added f: integration_test The flutter/packages/integration_test plugin platform-android Android applications specifically t: flutter driver "flutter driver", flutter_drive, or a driver test work in progress; do not review labels Aug 11, 2021

GaryQian mentioned this pull request Aug 11, 2021

Flake in DartIsolateTest.ValidLoadingUnitSucceeds #72312

Closed

GaryQian force-pushed the deferredintegration branch from 5eebf16 to 577396a Compare August 11, 2021 19:53

GaryQian force-pushed the deferredintegration branch 2 times, most recently from 0076a49 to 81fb4df Compare August 12, 2021 06:45

GaryQian changed the title ~~[WIP] Deferred components integration test app~~ Deferred components integration test app Aug 12, 2021

GaryQian requested a review from blasten August 12, 2021 06:46

GaryQian mentioned this pull request Aug 12, 2021

Add bundletool to DEPS and remove outdated header comment flutter/engine#28040

Merged

GaryQian force-pushed the deferredintegration branch from ee2a40b to 153cd6b Compare August 12, 2021 19:43

GaryQian requested a review from Piinks as a code owner August 12, 2021 19:43

GaryQian removed the request for review from Piinks August 12, 2021 19:52

GaryQian force-pushed the deferredintegration branch from 5f17537 to 84006b1 Compare August 12, 2021 20:49

blasten reviewed Aug 13, 2021

View reviewed changes

GaryQian requested a review from blasten August 13, 2021 08:48

blasten approved these changes Aug 13, 2021

View reviewed changes

blasten reviewed Aug 13, 2021

View reviewed changes

GaryQian added 11 commits August 16, 2021 13:12

Add Deferred Components integration test

a7fca55

Working tests

6891f16

Analyzer

b913920

Update pubspec deps

6bf686c

Misc deps upgrade

d3d9d9b

Analyzer passing

8ec06ad

remove extraneous icons

8fdfad0

Address comments

750c4c7

Skip gradle gen in deferred components apps

fc90c21

Use gradle generator and fix analyzer

e6114c6

Capture timestamp, skip settings.gradle for deferred components

1a601b1

GaryQian force-pushed the deferredintegration branch from 5d8c423 to 1a601b1 Compare August 16, 2021 20:48

GaryQian added waiting for tree to go green and removed work in progress; do not review labels Aug 16, 2021

fluttergithubbot merged commit a562b3c into flutter:master Aug 16, 2021

blasten pushed a commit to blasten/flutter that referenced this pull request Aug 19, 2021

Deferred components integration test app (flutter#88030)

81c3d10

Deferred components integration test app #88030

Deferred components integration test app #88030

Uh oh!

Conversation

GaryQian commented Aug 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skia-gold commented Aug 11, 2021

Uh oh!

skia-gold commented Aug 11, 2021

Uh oh!

skia-gold commented Aug 11, 2021

Uh oh!

blasten commented Aug 12, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blasten Aug 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blasten commented Aug 13, 2021

Uh oh!

blasten left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GaryQian commented Aug 14, 2021

Uh oh!

blasten commented Aug 14, 2021

Uh oh!

Uh oh!

GaryQian commented Aug 11, 2021 •

edited

Loading

blasten Aug 13, 2021 •

edited

Loading