Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed toggleableActiveColor #90317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixed toggleableActiveColor #90317

wants to merge 1 commit into from

Conversation

sm2017
Copy link

@sm2017 sm2017 commented Sep 18, 2021

I upgraded my flutter from 2.3 to 2.5 and fixes all deprecation including

info: 'accentColor' is deprecated and shouldn't be used. Use colorScheme.secondary instead. For more information, consult the migration guide at https://flutter.dev/docs/release/breaking-changes/theme-data-accent-properties#migration-guide. This feature was deprecated after v2.3.0-0.1.pre..

I just figured out that the color of checkbox is not true

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Sep 18, 2021
@goderbauer goderbauer added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Sep 27, 2021
@Hixie Hixie requested a review from goderbauer December 8, 2021 00:14
@goderbauer
Copy link
Member

@sm2017 Looks like this PR is failing checks. Can you please take a look at those? And while you're at it, resolve the merge conflict? Thanks!

@sm2017
Copy link
Author

sm2017 commented Dec 8, 2021

Sorry I'm too busy

@goderbauer
Copy link
Member

Ok. I am going to close this for now. Please feel free to re-open if you find the time to finish this PR. Thanks!

@goderbauer goderbauer closed this Dec 14, 2021
@TahaTesser TahaTesser mentioned this pull request Dec 27, 2021
Closed
8 tasks
@TahaTesser TahaTesser mentioned this pull request Apr 22, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sm2017 @goderbauer