Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update outdated runners in the integration_tests #91127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Update outdated runners in the integration_tests #91127

wants to merge 3 commits into from

Conversation

gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Oct 1, 2021 •
edited
Loading

Description

This PR updates the platform runners in the integration_tests subdir.

I've attempted to replace the entire group with new code as if the project were recreated with flutter create so that they don't become a Frankenstein of minor changes to make it work again, but just plain old generated code that can be replaced and updated in place.

Tests

  • No tests because we're just updating boilerplate here.

Related Issues

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: integration_test The flutter/packages/integration_test plugin c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 1, 2021
@google-cla google-cla bot added the cla: yes label Oct 1, 2021
@gspencergoog gspencergoog force-pushed the update_embeddings_3 branch 2 times, most recently from cecb3b7 to e7c264e Compare October 5, 2021 18:47
@gspencergoog gspencergoog marked this pull request as ready for review October 5, 2021 21:38
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@gspencergoog gspencergoog changed the title Update outdated embeddings in the integration_tests Update outdated runners in the integration_tests Oct 5, 2021
@Hixie
Copy link
Contributor

Hixie commented Oct 5, 2021

test-exempt: refactor with no semantic change (applying new boilerplate)

@gspencergoog
Copy link
Contributor Author

@blasten Should I be checking in the lockfiles themselves after running generate_gradle_lockfiles.dart? (e.g. dev/integration_tests/external_ui/android/buildscript-gradle.lockfile)

@blasten
Copy link

blasten commented Oct 7, 2021

Should I be checking in the lockfiles themselves after running generate_gradle_lockfiles.dart

That's right.

apologies for the conflicts.

@gspencergoog
Copy link
Contributor Author

gspencergoog commented Oct 7, 2021 •
edited
Loading

Oh, no worries, I was waiting until #90642 landed anyhow, so now I'll merge and try to land.

@gspencergoog gspencergoog force-pushed the update_embeddings_3 branch 2 times, most recently from 64e6f50 to 98e0ac6 Compare October 19, 2021 16:11
@gspencergoog gspencergoog requested a review from blasten October 19, 2021 16:11
blasten
blasten reviewed Oct 19, 2021
View reviewed changes
dev/integration_tests/abstract_method_smoke_test/android/build.gradle Outdated
@@ -34,8 +34,6 @@ rootProject.buildDir = '../build'

subprojects {
project.buildDir = "${rootProject.buildDir}/${project.name}"
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that https://github.com/flutter/flutter/pull/91030/files forgot to update generate_gradle_lockfiles.dart

Having this separation was intentional #91018

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, @blasten, so should I update the script to include the separation, or is there more to it than that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nm: looks like you already updated it.

@gspencergoog
Copy link
Contributor Author

Closing so @blasten can take over landing this.

@Hixie
Copy link
Contributor

Hixie commented Nov 15, 2021

Is there a new PR replacing this one? (Asking on behalf of future archeologists following links from test.dart...)

@gspencergoog
Copy link
Contributor Author

No, it appears that this was never actually landed.

@gspencergoog gspencergoog deleted the update_embeddings_3 branch October 7, 2022 22:02
@pdblasi-google
Copy link
Contributor

@gspencergoog
I am a future archeologist from test.dart!

As this PR was closed and a different PR wasn't created/landed, is there an issue that would be better to point to in the test.dart file?

@gspencergoog
Copy link
Contributor Author

No, there was never an issue filed for this. I'll make one.

@gspencergoog gspencergoog mentioned this pull request Oct 20, 2022
Open
33 tasks
@gspencergoog
Copy link
Contributor Author

Here's the filed issue. Haven't updated the comment in test.dart yet.

#113782

@pdblasi-google
Copy link
Contributor

If you'd like, I can update the comment while I'm in the area.

@gspencergoog
Copy link
Contributor Author

Sure, that would be great.

@pdblasi-google
Copy link
Contributor

Alright, the comment should be updated when #113784 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blasten blasten blasten left review comments

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. f: integration_test The flutter/packages/integration_test plugin tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gspencergoog @Hixie @blasten @pdblasi-google