Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ThemeData property cleanup. #91774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 14, 2021
Merged

ThemeData property cleanup. #91774

merged 4 commits into from
Oct 14, 2021

Conversation

darrenaustin
Copy link
Contributor

Addresses most of the issues raised in #91587. Made sure all of the properties in the raw constructor, lerp, operator ==, and hashcode functions are the same and in the same order. Also added missing properties in the diagnostics and fixed some naming issues there as well.

Fixes #91587.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Oct 13, 2021
@google-cla google-cla bot added the cla: yes label Oct 13, 2021
HansMuller
HansMuller reviewed Oct 13, 2021
View reviewed changes
@darrenaustin darrenaustin mentioned this pull request Oct 14, 2021
Merged
8 tasks
HansMuller
HansMuller approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yash1200 yash1200 mentioned this pull request Oct 14, 2021
Closed
8 tasks
@rydmike
Copy link
Contributor

rydmike commented Oct 14, 2021

Thanks, this looks good.

@darrenaustin darrenaustin merged commit ac745b3 into flutter:master Oct 14, 2021
@darrenaustin darrenaustin deleted the theme_data_issues branch October 14, 2021 22:14
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@darrenaustin @clocksmith
ThemeData property cleanup. (flutter#91774)
9485210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ThemeData issues with operator, copyWith and debugFillProperties
3 participants
@darrenaustin @rydmike @HansMuller