It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@maxzod This looks great, would you mind fixing the import order to be alphabetical? Then we can land it!

@maxzod This looks great, would you mind fixing the import order to be alphabetical? Then we can land it!

done .👍

I think I understand what this review does, but I'm missing a better description of the change; in particular:

I listed at least one issue that this PR fixes in the description above.

Is checked in the pre-launch checklist, but there's no issue linked (or information about what this does, really).

@maxzod can you provide more context, and maybe an issue? If the problem is maybe too trivial to open a new issue in flutter/flutter, can the description of this PR be updated to provide said context/extra information?

When we go back to this PR in X months (or to maybe auto-generate a cool changelog), it should be easy to understand what this fixed, and why this needed to be done.

Thanks for the contribution!

@maxzod also if you wouldn't mind rebasing the change to tip of tree, that should unblock the tests (unfortunately your PR is branched from before a point where we had to change our tokens, so the tests are failing on old tokens).

@Hixie , the branch has the latest changes in the master until this comment
@ditman , i have opened a issue and listen it in the PR (#97479)

Thanks @maxzod! Note that if you list the PR as "Fixes #ISSUE_NUMBER_OR_LINK", Github will automatically link the issue and this PR, so the issue will get closed when this PR lands! (see this Github docs, very handy!).

I've done it for this PR (check the description above).

ERROR: One or more tests from rainbowmonkey failed.
Deleting temporary directory...
Contact: @Hixie

@Hixie, are the customer_testing-linux tests safe to restart? Maybe this PR needs a merge from master for CI to pass again?

when will this be merged 🤔

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Apologies @maxzod, I have been busy with other stuff and didn't see this notification. I've approved your change, and merged this with the latest master.

I've also applied the 'waiting for tree to go green' tag, so it lands as soon as all tests pass (and flutter/flutter is ready to accept new changes!)

Thanks for your contribution, keep them coming!

This pull request is not suitable for automatic merging in its current state.

• The status or check suite customer_testing-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

Hey team, this very innocent-looking PR is breaking several customer tests: rfw, flutter_svg and rainbowmonkey... How come?

(Pinging owners: @goderbauer, @Hixie, @dnfield (?))

This PR probably just needs to be rebased to the current master to make those errors go away.

This PR probably just needs to be rebased to the current master to make those errors go away.

@goderbauer tried that already, this branch is at the tip of master, if git is to be believed.

@dnfield might have a point (from Discord): "Make sure to explicitly use git rebase, not git merge, since rebase is the only way to get the script to find the right branch point to pick for updates to customer testing"

(Rebasing and push-forcing the branch)