Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "ChipThemeData is now conventional" #93797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2021
Merged

Revert "ChipThemeData is now conventional" #93797

merged 1 commit into from
Nov 20, 2021

Conversation

HansMuller
Copy link
Contributor

Reverts #93452

References to previously non-nullable fields can fail. See Google internal issue - b/206734686

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Nov 17, 2021
@google-cla google-cla bot added the cla: yes label Nov 17, 2021
justinmc
justinmc approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert LGTM 👍

@Piinks
Copy link
Contributor

Piinks commented Nov 17, 2021

Just a flyby triage comment for when this re-lands: it should be marked as a breaking change and get a migration guide :)

@HansMuller HansMuller mentioned this pull request Nov 20, 2021
Open
42 tasks
@fluttergithubbot fluttergithubbot merged commit ab7161f into master Nov 20, 2021
@fluttergithubbot fluttergithubbot deleted the revert-93452-update_chip_theme branch November 20, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc justinmc approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HansMuller @Piinks @justinmc @fluttergithubbot