Make chip test not depend on child order #94624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
commented
Dec 3, 2021
| @@ -307,7 +307,7 @@ void main() { | |||
| expect(getIconData(tester).color?.value, 0xffffffff); | |||
| expect(getIconData(tester).opacity, null); | |||
| expect(getIconData(tester).size, null); | |||
| expect(getLabelStyle(tester).style.color?.value, 0xffffffff); | |||
| expect(getLabelStyle(tester, 'Chip A').style.color?.value, 0xdeffffff); | |||
There was a problem hiding this comment.
@HansMuller Can you double-check that this is actually what the color should be in this case? It matches what the ChoiceChip already asserts.
HansMuller
approved these changes
Dec 3, 2021
| @@ -307,7 +307,7 @@ void main() { | |||
| expect(getIconData(tester).color?.value, 0xffffffff); | |||
| expect(getIconData(tester).opacity, null); | |||
| expect(getIconData(tester).size, null); | |||
| expect(getLabelStyle(tester).style.color?.value, 0xffffffff); | |||
| expect(getLabelStyle(tester, 'Chip A').style.color?.value, 0xdeffffff); | |||
| find.descendant( | ||
| of: find.byType(RawChip), | ||
| find.ancestor( | ||
| of: find.text(labelText), |
|
This pull request is not suitable for automatic merging in its current state.
|
goderbauer
added a commit
to goderbauer/flutter
that referenced
this pull request
Dec 3, 2021
…94077)" Test was fixed in flutter#94624.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of Chip has a subtle bug where the during initial build the child elements are ordered avatar, deleteIcon, label:
flutter/packages/flutter/lib/src/material/chip.dart
Lines 2163 to 2165 in 4517d16
During subsequent builds, the order is changed to label, avatar, deleteIcon:
flutter/packages/flutter/lib/src/material/chip.dart
Lines 2183 to 2185 in 4517d16
However, in
chip_test.dartthegetLabelStylemethod is assuming that the label is always the last child:flutter/packages/flutter/test/material/chip_test.dart
Lines 49 to 56 in 4517d16
This is only true after initial build. If a test rebuilds the chip, the label is the middle child and
getLabelStylereturns the incorrect style of the deleteIcon. This PR fixesgetLabelStyleto no longer rely on the child order of Chip. As it turns out, one of the test cases introduced in #94179 was making incorrect assumptions about the label style because of this bug. That assumption is fixed as well.The bug was discovered when #94077 unified the child order of first and subsequent builds.