Reland "Ensure the engineLayer is disposed when an OpacityLayer is disabled""#96295
Merged
fluttergithubbot merged 1 commit intoJan 7, 2022
Merged
Conversation
zanderso
approved these changes
Jan 7, 2022
Member
zanderso
left a comment
There was a problem hiding this comment.
Please add the cp: 2.10 label to one of the issues, and link to this PR.
Contributor
Author
|
Added the CP label. This should be relatively easy to CP in to stable. |
renyou
approved these changes
Jan 7, 2022
|
Is there a way to get notified when this is cherrypicked into stable? |
|
I would be interested in this fix and notification as well. |
Contributor
Author
|
See #94906 (comment) |
itsjustkevin
added a commit
that referenced
this pull request
Jan 19, 2022
…96872) * RawKeyboard repeat events, and SingleActivator.includeRepeats (#96154) * Reland "Ensure the engineLayer is disposed when an OpacityLayer is disabled"" (#96295) * Update Flutter desktop doc URL in error message (#96559) When desktop support is not present in an existing project, certain flutter tool commands raise an error that direct the user to documentation on how to add desktop support to an existing Flutter project. In a recent revamp of the webside, the URL was very slightly changed (flutter.dev -> docs.flutter.dev). This updates the error message to output the new URL. Issue: #94398 * 'add branch flutter-2.8-candidate.16 to enabled_branches in .ci.yaml' * 'Update Engine revision to 74b74b1 for beta release 2.10.0-0.2.pre' * Removed unnecessary reference to enabled_branches Co-authored-by: Tong Mu <[email protected]> Co-authored-by: Dan Field <[email protected]> Co-authored-by: Chris Bracken <[email protected]> Co-authored-by: Kevin Chisholm <[email protected]>
passsy
added a commit
to wiredashio/wiredash-sdk
that referenced
this pull request
Feb 5, 2022
Don't show statusbar when switching from portrait to landscape. This is caused by flutter/flutter#96295 It's fixed in Flutter 2.10 but not in earlier versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #94743
@ctrysbita @goderbauer @Piinks @jason-simmons fyi
The internal scuba breakages were actually regressions caused by #90017, which were missed because that PR affected 1000s of scubas by a few pixels. Compare
<redacted>/test/scuba_goldens/linux/off_to_on_step_3.pngbefore cl/397080291 and after. These were just unfortunately real regressions we missed.This PR will require updating a few scuba files (something like 10 or so) internally - this is expected. /cc @renyou @angjieli fyi.
Fixes #92830 (again)
fixes #95911
fixes #94906
fixes #96087
Fixes #95270
We should CP this into stable.