Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rename iOS Flutter.xcframework directory ios-arm64_armv7 -> ios-arm64 #97344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Rename iOS Flutter.xcframework directory ios-arm64_armv7 -> ios-arm64 #97344

wants to merge 1 commit into from

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jan 27, 2022

Must be merged in the same engine roll that removes armv7 from the engine artifacts. Do not merge.

Tool half of #97342

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 27, 2022
@jmagman jmagman self-assigned this Jan 27, 2022
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jan 27, 2022
@jmagman jmagman mentioned this pull request Jan 27, 2022
Closed
@jmagman jmagman added platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management labels Jan 27, 2022
@jmagman jmagman mentioned this pull request Apr 8, 2022
Merged
8 tasks
@jmagman
Copy link
Member Author

jmagman commented Apr 8, 2022

Superceded by #97341 and #101592

@jmagman jmagman closed this Apr 8, 2022
@jmagman jmagman deleted the armv7-xcframework branch May 4, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matanlurey matanlurey Awaiting requested review from matanlurey matanlurey will be requested when the pull request is marked ready for review matanlurey is a code owner

Assignees

@jmagman jmagman

Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmagman