Simplify SafeArea test for maintainBottomViewPadding to ensure maintainBottomViewPadding is always respected #97646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent flutter engine changes enable iOS MediaQuery bottom viewInsets and padding to be !=0 simultaneously. This condition resulted in maintainBottomViewPadding being ignored. This commit forces use of viewPadding.bottom when maintainBottomViewPadding is true. Resolves issue flutter#97609.
|
I offer the following justification for the much-simplified condition concerning bottom padding: Assuming maintainBottomViewPadding is true and knowing that padding is calculated...
In all cases, it is valid to use viewPadding when maintainBottomViewPadding is true. This is also semantically aligned with the property name itself, which does not imply conditional behaviour based on viewInsets/padding. |
Piinks
reviewed
Feb 17, 2022
There was a problem hiding this comment.
Hey @joellurcook, thanks for the contribution! Just a few nits below per the style guide. Thanks for fixing this!
|
I assume the failing checks are unrelated to the PR content - is there a simple way to prod the checks to be performed again? |
Piinks
approved these changes
Feb 24, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 3, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 3, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 3, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 3, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 3, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 3, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2022
…e maintainBottomViewPadding is always respected (flutter/flutter#97646)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent flutter engine changes enable iOS MediaQuery bottom viewInsets and padding to be !=0 simultaneously (see flutter/engine#29281).
This condition resulted in SafeArea maintainBottomViewPadding being ignored during keyboard animation.
This commit forces use of viewPadding.bottom when maintainBottomViewPadding is true.
This fixes the following issue:
fixes #97609.
No changes to existing tests.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.