-
Notifications
You must be signed in to change notification settings - Fork 28.7k
Update dependencies to pull in new vm_service, dds, dwds, coverage, etc #98513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm investigating why analyzer got downgraded in this change
We discussed the in discord that the downgrade is being constrained by DWDS. Unrelated, it looks like there may be a Dart compilation failure with this change from CI:
|
cc @elliette who is working on publishing an updated dwds with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks for the fix. customer_testing on cirrus will unfortunately only be fixed by a rebase (not merge) upstream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still lgtm
SkiaPerf is reporting a ~20ms improvement in DevFS sync time on this change Is that expected? |
There weren't any changes in DDS or the service that should have impacted DevFS latency, but if we're seeing a consistent improvement I'm not going to complain... :-) |
No description provided.