Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update mac chrome and driver to 98. #99318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 1, 2022
Merged

Update mac chrome and driver to 98. #99318

merged 4 commits into from
Mar 1, 2022

Conversation

godofredoc
Copy link
Contributor

Chrome 84 was not working properly on mac 12.2. This is required to
migrate the remaining 50% of the mac fleet.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Update mac chrome and driver to 98.
6badf51 
Chrome 84 was not working properly on mac 12.2. This is required to
migrate the remaining 50% of the mac fleet.
@CaseyHillers
Copy link
Contributor

FYI mac web tool tests is failing

@godofredoc
Copy link
Contributor Author

FYI mac web tool tests is failing

Yeah the web-engine team and plugins are checking the failures.

@godofredoc godofredoc requested a review from jmagman March 1, 2022 20:39
@godofredoc
Copy link
Contributor Author

@jmagman this is ready to land. The issue was the path in the cipd package.

jmagman
jmagman approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for working on this!
LGTM

@jmagman jmagman mentioned this pull request Mar 1, 2022
Merged
8 tasks
@goderbauer goderbauer added c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team labels Mar 1, 2022
@fluttergithubbot fluttergithubbot merged commit 4d217d2 into flutter:master Mar 1, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
4a9d0ba
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 1, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
4076d5c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
189e8ff
@ditman ditman mentioned this pull request Mar 1, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
20428ba
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
6bb4fe3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
23397b9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
e6567c9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
d03fa8c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
feccb21
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
bf850a6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
09e441c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
64229d9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
f2e3d86
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
a7d77a9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
6db7605
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
020e893
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
f62b459
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
0240000
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
16b528b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
395cfa5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
713e7e0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
57b9fba
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
c4de29e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
9a65e03
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
6eee905
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
d383342
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
e6889a2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
21327f1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
70f90ff
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
953df91
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
23bf99a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
0204df3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
513e5e0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
afdc208
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
4d217d2 Update mac chrome and driver to 98. (flutter/flutter#99318)
106059d
@godofredoc godofredoc deleted the update_chrome branch April 20, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman jmagman approved these changes

@keyonghan keyonghan Awaiting requested review from keyonghan

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@godofredoc @CaseyHillers @jmagman @goderbauer @fluttergithubbot