Add Windows performance benchmark #99564

jonahwilliams · 2022-03-04T19:18:06Z

We need at least one benchmark to test if flutter/engine#31830 improves rendering performance.

This adds a single windows host benchmark, with a small change to the tool to simplify devicelab integration

keyonghan · 2022-03-04T20:07:46Z

.ci.yaml

@@ -4403,6 +4403,17 @@ targets:
      - bin/**
      - .ci.yaml

+  - name: Windows home_scroll_perf__timeline_summary


Builder name follows the format Platform + task name: Windows home_scroll_perf__timeline_summary => Windows windows_home_scroll_perf__timeline_summary

Not sure if this will fail the led run, will try based on this PR to see how it goes.

jonahwilliams · 2022-03-04T20:54:21Z

Updated the tool so it now supports non-fatal --screenshot on unsupported devices

jonahwilliams · 2022-03-04T21:00:27Z

packages/flutter_tools/test/commands.shard/hermetic/drive_test.dart

@@ -45,6 +45,38 @@ void main() {
    Cache.enableLocking();
  });

+  testUsingContext('warns if screenshot is not supported but continues test', () async {


FYI @christopherfujino , this is a lot easier than tracking whether each device supports screenshotting in the devicelab codebase

keyonghan

We also need an entry in ownership file: https://github.com/flutter/flutter/blob/master/TESTOWNERS to bypass the owner check.

keyonghan · 2022-03-04T21:05:25Z

.ci.yaml

@@ -4403,6 +4403,17 @@ targets:
      - bin/**
      - .ci.yaml

+  - name: Windows windows_home_scroll_perf__timeline_summary
+    recipe: devicelab/devicelab_drone
+    presubmit: true


The current workflow is using bringup: true first.
We don't need presubmit: true here: 1) ci yaml roller use default value true for presubmit 2) With this set, it will cause the presubmit hang on this test as there is not available builder config yet.

keyonghan · 2022-03-04T21:19:59Z

TESTOWNERS

+## Windows Devicelab tests
+/dev/devicelab/bin/tasks/windows_home_scroll_perf__timeline_summary.dart @jonahwilliams @flutter/engine
+


Nit: this can be added in section: ## Host only DeviceLab tests

keyonghan

LGTM re CI config.

dnfield

Test LGTM

christopherfujino

LGTM

christopherfujino · 2022-03-04T23:31:04Z

packages/flutter_tools/test/commands.shard/hermetic/drive_test.dart

@@ -45,6 +45,38 @@ void main() {
    Cache.enableLocking();
  });

+  testUsingContext('warns if screenshot is not supported but continues test', () async {


@jonahwilliams

…presubmit (#125343) Introduced in #99564. Checked with @jonahwilliams and this should not be running in presubmit.

add windows benchmark

f31862b

flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 4, 2022

jonahwilliams mentioned this pull request Mar 4, 2022

[windows] use angle fast path on d3d11 backend flutter/engine#31830

Merged

keyonghan reviewed Mar 4, 2022

View reviewed changes

make --screenshot on unsupported device non-fatal

b88c1d2

jonahwilliams requested a review from christopherfujino March 4, 2022 20:54

jonahwilliams commented Mar 4, 2022

View reviewed changes

keyonghan reviewed Mar 4, 2022

View reviewed changes

Update .ci.yaml

27c7632

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 4, 2022

jonahwilliams marked this pull request as ready for review March 4, 2022 21:08

jonahwilliams requested a review from CaseyHillers as a code owner March 4, 2022 21:08

jonahwilliams changed the title ~~add windows benchmark~~ Add Windows performance benchmark Mar 4, 2022

update TESTOWNERS

82bc2d1

keyonghan reviewed Mar 4, 2022

View reviewed changes

Update TESTOWNERS

40a9dab

keyonghan approved these changes Mar 4, 2022

View reviewed changes

dnfield approved these changes Mar 4, 2022

View reviewed changes

jonahwilliams added the waiting for tree to go green label Mar 4, 2022

christopherfujino approved these changes Mar 4, 2022

View reviewed changes

fluttergithubbot merged commit 59859df into flutter:master Mar 4, 2022

engine-flutter-autoroll mentioned this pull request Mar 4, 2022

Roll Flutter from 513df67edb69 to 59859df1265a (3 revisions) flutter/plugins#5009

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 4, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

7b4bb21

engine-flutter-autoroll mentioned this pull request Mar 4, 2022

Roll Flutter from 38dbbb17f8ce to 8e6d57b7735a (56 revisions) flutter/packages#1062

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

0357ac0

engine-flutter-autoroll mentioned this pull request Mar 5, 2022

Roll Flutter from 38dbbb17f8ce to 03c92a99fdf8 (57 revisions) flutter/packages#1063

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

5faff49

engine-flutter-autoroll mentioned this pull request Mar 5, 2022

Roll Flutter from 513df67edb69 to 03c92a99fdf8 (5 revisions) flutter/plugins#5010

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

0d6f542

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

b99cd46

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

20b8805

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

340a8e3

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

c56b22e

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

f8de301

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

b4aea3c

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

1a946eb

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

95b07da

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

7f38ff7

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

d0655d7

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

47b607c

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

20fead4

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

30c2937

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

1dfa550

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

9960a57

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

f339fd8

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

cecab8a

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

e0a0b26

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

7dadde2

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

c35e7d3

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

d6c558e

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

e921926

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

1d8414d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

610c6f6

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

59859df Add Windows performance benchmark (flutter/flutter#99564)

3423519

jmagman mentioned this pull request Apr 21, 2023

Do not run windows_home_scroll_perf__timeline_summary benchmark in presubmit #125343

Merged

8 tasks

auto-submit bot pushed a commit that referenced this pull request Apr 24, 2023

Do not run windows_home_scroll_perf__timeline_summary benchmark in …

9e2e64c

…presubmit (#125343) Introduced in #99564. Checked with @jonahwilliams and this should not be running in presubmit.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Windows performance benchmark #99564

Add Windows performance benchmark #99564

Uh oh!

jonahwilliams commented Mar 4, 2022 •

edited

Loading

Uh oh!

keyonghan Mar 4, 2022

Uh oh!

keyonghan Mar 4, 2022

Uh oh!

jonahwilliams Mar 4, 2022

Uh oh!

jonahwilliams commented Mar 4, 2022

Uh oh!

jonahwilliams Mar 4, 2022

Uh oh!

christopherfujino Mar 4, 2022

Uh oh!

keyonghan left a comment

Uh oh!

keyonghan Mar 4, 2022

Uh oh!

jonahwilliams Mar 4, 2022

Uh oh!

keyonghan Mar 4, 2022

Uh oh!

jonahwilliams Mar 4, 2022

Uh oh!

keyonghan left a comment

Uh oh!

dnfield left a comment

Uh oh!

christopherfujino left a comment

Uh oh!

christopherfujino Mar 4, 2022

Uh oh!

Uh oh!

		## Windows Devicelab tests
		/dev/devicelab/bin/tasks/windows_home_scroll_perf__timeline_summary.dart @jonahwilliams @flutter/engine

Add Windows performance benchmark #99564

Add Windows performance benchmark #99564

Uh oh!

Conversation

jonahwilliams commented Mar 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonahwilliams commented Mar 4, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

keyonghan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

keyonghan left a comment

Choose a reason for hiding this comment

Uh oh!

dnfield left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jonahwilliams commented Mar 4, 2022 •

edited

Loading